Issue 17335010: Print a nicer error if installing an APK fails when you have not run adb root.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17335010: Print a nicer error if installing an APK fails when you have not run adb root. (Closed)

Created:
7 years, 6 months ago by Ted C

Modified:
7 years, 6 months ago

Reviewers:
cjhopman

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Print a nicer error if installing an APK fails when you have not run adb root. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207585

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	build/android/gyp/apk_install.py	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/17335010/1

7 years, 6 months ago (2013-06-19 18:38:47 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 6 months ago (2013-06-19 19:02:28 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/17335010/1

7 years, 6 months ago (2013-06-20 01:53:57 UTC) #5

Message was sent while issue was closed.

Change committed as 207585

Expand Messages | Collapse Messages