Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: content/browser/dom_storage/dom_storage_message_filter.cc

Issue 17327004: Replace base::NullableString16(bool) usage with default constructor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/dom_storage/dom_storage_message_filter.h" 5 #include "content/browser/dom_storage/dom_storage_message_filter.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/strings/nullable_string16.h" 9 #include "base/strings/nullable_string16.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 old_value); 166 old_value);
167 } 167 }
168 168
169 void DOMStorageMessageFilter::OnDomStorageItemRemoved( 169 void DOMStorageMessageFilter::OnDomStorageItemRemoved(
170 const dom_storage::DomStorageArea* area, 170 const dom_storage::DomStorageArea* area,
171 const string16& key, 171 const string16& key,
172 const string16& old_value, 172 const string16& old_value,
173 const GURL& page_url) { 173 const GURL& page_url) {
174 SendDomStorageEvent(area, page_url, 174 SendDomStorageEvent(area, page_url,
175 base::NullableString16(key, false), 175 base::NullableString16(key, false),
176 base::NullableString16(true), 176 base::NullableString16(),
177 base::NullableString16(old_value, false)); 177 base::NullableString16(old_value, false));
178 } 178 }
179 179
180 void DOMStorageMessageFilter::OnDomStorageAreaCleared( 180 void DOMStorageMessageFilter::OnDomStorageAreaCleared(
181 const dom_storage::DomStorageArea* area, 181 const dom_storage::DomStorageArea* area,
182 const GURL& page_url) { 182 const GURL& page_url) {
183 SendDomStorageEvent(area, page_url, 183 SendDomStorageEvent(area, page_url,
184 base::NullableString16(true), 184 base::NullableString16(),
185 base::NullableString16(true), 185 base::NullableString16(),
186 base::NullableString16(true)); 186 base::NullableString16());
187 } 187 }
188 188
189 void DOMStorageMessageFilter::SendDomStorageEvent( 189 void DOMStorageMessageFilter::SendDomStorageEvent(
190 const dom_storage::DomStorageArea* area, 190 const dom_storage::DomStorageArea* area,
191 const GURL& page_url, 191 const GURL& page_url,
192 const base::NullableString16& key, 192 const base::NullableString16& key,
193 const base::NullableString16& new_value, 193 const base::NullableString16& new_value,
194 const base::NullableString16& old_value) { 194 const base::NullableString16& old_value) {
195 DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::IO)); 195 DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::IO));
196 // Only send mutation events to processes which have the area open. 196 // Only send mutation events to processes which have the area open.
197 bool originated_in_process = connection_dispatching_message_for_ != 0; 197 bool originated_in_process = connection_dispatching_message_for_ != 0;
198 if (originated_in_process || 198 if (originated_in_process ||
199 host_->HasAreaOpen(area->namespace_id(), area->origin())) { 199 host_->HasAreaOpen(area->namespace_id(), area->origin())) {
200 DOMStorageMsg_Event_Params params; 200 DOMStorageMsg_Event_Params params;
201 params.origin = area->origin(); 201 params.origin = area->origin();
202 params.page_url = page_url; 202 params.page_url = page_url;
203 params.connection_id = connection_dispatching_message_for_; 203 params.connection_id = connection_dispatching_message_for_;
204 params.key = key; 204 params.key = key;
205 params.new_value = new_value; 205 params.new_value = new_value;
206 params.old_value = old_value; 206 params.old_value = old_value;
207 params.namespace_id = area->namespace_id(); 207 params.namespace_id = area->namespace_id();
208 Send(new DOMStorageMsg_Event(params)); 208 Send(new DOMStorageMsg_Event(params));
209 } 209 }
210 } 210 }
211 211
212 } // namespace content 212 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698