Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 1731673002: Add tab reparenting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove test Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index cd0a59ae9e74325ce7629ea57e28c20970b9b09b..851e19950f8a422ab0226caf66b705dd69afe36b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -40,9 +40,6 @@ public class AppBannerManager extends EmptyTabObserver {
/** Pointer to the native side AppBannerManager. */
private long mNativePointer;
- /** Tab that the AppBannerView/AppBannerManager is owned by. */
- private final Tab mTab;
-
/**
* Checks if app banners are enabled.
* @return True if banners are enabled, false otherwise.
@@ -70,19 +67,18 @@ public class AppBannerManager extends EmptyTabObserver {
*/
public AppBannerManager(Tab tab, Context context) {
mNativePointer = nativeInit();
- mTab = tab;
- updatePointers();
+ updatePointers(tab);
}
@Override
public void onWebContentsSwapped(Tab tab, boolean didStartLoad,
boolean didFinishLoad) {
- updatePointers();
+ updatePointers(tab);
}
@Override
public void onContentChanged(Tab tab) {
- updatePointers();
+ updatePointers(tab);
}
/**
@@ -96,8 +92,8 @@ public class AppBannerManager extends EmptyTabObserver {
/**
* Updates which WebContents the native AppBannerManager is monitoring.
*/
- private void updatePointers() {
- nativeReplaceWebContents(mNativePointer, mTab.getWebContents());
+ private void updatePointers(Tab tab) {
+ nativeReplaceWebContents(mNativePointer, tab.getWebContents());
}
/**

Powered by Google App Engine
This is Rietveld 408576698