Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3855)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java

Issue 1731673002: Add tab reparenting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java
index c2c55e060cc1e038b69fc615af62bef31ccb4989..5948b19e2152654ffb01c461bc5dea85d7df2d3b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java
@@ -84,6 +84,11 @@ public class TabModelImpl extends TabModelJniBridge {
}
@Override
+ public void removeTab(Tab tab) {
+ mTabs.remove(tab);
+ }
+
+ @Override
public void destroy() {
for (Tab tab : mTabs) {
if (tab.isInitialized()) tab.destroy();
@@ -116,10 +121,10 @@ public class TabModelImpl extends TabModelJniBridge {
TraceEvent.begin("TabModelImpl.addTab");
for (TabModelObserver obs : mObservers) obs.willAddTab(tab, type);
-
boolean selectTab = mOrderController.willOpenInForeground(type, isIncognito());
index = mOrderController.determineInsertionIndex(type, index, tab);
+
gone 2016/02/24 18:40:37 nit: remove whitespace
Yusuf 2016/02/24 19:40:35 Done.
assert index <= mTabs.size();
assert tab.isIncognito() == isIncognito();

Powered by Google App Engine
This is Rietveld 408576698