chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 1731673002: Add tab reparenting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1731673002: Add tab reparenting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index ed00ff56ff0afa72a2135bd35059470938dca441..cfbc36bbe972503852d4a336ac4b4fc89e52185d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -104,6 +104,7 @@ import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarManageable;

import org.chromium.chrome.browser.sync.ProfileSyncService;

import org.chromium.chrome.browser.sync.SyncController;

import org.chromium.chrome.browser.tab.Tab;

+import org.chromium.chrome.browser.tabmodel.AsyncTabParamsManager;

import org.chromium.chrome.browser.tabmodel.ChromeTabCreator;

import org.chromium.chrome.browser.tabmodel.EmptyTabModel;

import org.chromium.chrome.browser.tabmodel.TabCreatorManager;

@@ -697,6 +698,9 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

@Override

public void onStart() {

+ if (mCompositorViewHolder != null && AsyncTabParamsManager.hasParamsWithTabToReparent()) {

+ mCompositorViewHolder.onActiveTabReparented();

+ }

super.onStart();

if (mContextReporter != null) mContextReporter.enable();