Add tab reparenting

chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.tab;
 
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
 import android.content.res.Resources;
@@ skipping 135 matching lines @@
     /** Whether or not this tab is an incognito tab. */
     private final boolean mIncognito;
 
     /**
      * An Application {@link Context}.  Unlike {@link #mActivity}, this is the only one that is
      * publicly exposed to help prevent leaking the {@link Activity}.
      */
     private final Context mThemedApplicationContext;
 
     /** Gives {@link Tab} a way to interact with the Android window. */
-    private final WindowAndroid mWindowAndroid;
+    private WindowAndroid mWindowAndroid;
 
     /** Whether or not this {@link Tab} is initialized and should be interacted with. */
     private boolean mIsInitialized;
 
     /** The current native page (e.g. chrome-native://newtab), or {@code null} if there is none. */
     private NativePage mNativePage;
 
     /** InfoBar container to show InfoBars for this tab. */
     private InfoBarContainer mInfoBarContainer;
 
@@ skipping 1181 matching lines @@
         } finally {
             if (mTimestampMillis == INVALID_TIMESTAMP) {
                 mTimestampMillis = System.currentTimeMillis();
             }
 
             TraceEvent.end("Tab.initialize");
         }
     }
 
     /**
+     * Detaches tab and related objects from an existing activity and attaches to a new one. This
+     * updates many delegates inside the tab and {@link ContentViewCore} both on java and native
+     * sides.
+     * @param activity The new activity this tab should be associated with.
+     * @param tabDelegateFactory The new delegate factory this tab should be using.
+     */
+    public void reparentToActivity(ChromeActivity activity, TabDelegateFactory tabDelegateFactory) {
+        ChromeActivity oldActivity = getActivity();
+
+        // Update and propagate for the new WindowAndroid.
+        mWindowAndroid = activity.getWindowAndroid();
+        mContentViewCore.updateWindowAndroid(mWindowAndroid);
+
+        // Update for the controllers that needs the Compositor from the new Activity.

[gone, 2016/02/24 18:40:37]

needs -> need

[Yusuf, 2016/02/24 19:40:35]

Done.

+        nativeAttachToTabContentManager(mNativeTabAndroid, activity.getTabContentManager());
+        mFullscreenManager = activity.getFullscreenManager();
+        activity.getCompositorViewHolder().onActiveTabReparented();
+
+        // Update the delegate factory, then recreate and propagate all delegates.
+        mDelegateFactory = tabDelegateFactory;
+        mWebContentsDelegate = mDelegateFactory.createWebContentsDelegate(this);
+        nativeUpdateDelegates(mNativeTabAndroid,
+                mWebContentsDelegate, mDelegateFactory.createContextMenuPopulator(this));
+        mTopControlsVisibilityDelegate = mDelegateFactory.createTopControlsVisibilityDelegate(this);
+        setInterceptNavigationDelegate(mDelegateFactory.createInterceptNavigationDelegate(this));
+        mAppBannerManager = mDelegateFactory.createAppBannerManager(this);

[gone, 2016/02/24 18:40:37]

You're not calling mAppBannerManager.destroy() on the old one, which has a
native pointer.  Are you missing any other destroy() calls for the ones you're
replacing?

[Yusuf, 2016/02/24 19:40:35]

Done.
No, the appbannermanager is the only one. And I had totally checked this all
before you told me to...

+
+        // Take down the old activity, which destroys all the remaining tabmodels and tabs.
+        if (oldActivity != null && !oldActivity.isActivityDestroyed()) oldActivity.finish();
+    }
+
+    /**
      * @return The delegate factory for testing purposes only.
      */
     public TabDelegateFactory getDelegateFactory() {
         return mDelegateFactory;
     }
 
     /**
      * Used to get a list of Android {@link View}s that represent both the normal content as well as
      * overlays.  This does not return {@link View}s for {@link NativePage}s.
      * @param content A {@link List} that will be populated with {@link View}s that represent all of
@@ skipping 1570 matching lines @@
         String packageName = ApplicationStatus.getApplicationContext().getPackageName();
         return getLaunchType() == TabLaunchType.FROM_EXTERNAL_APP
                 && !TextUtils.equals(getAppAssociatedWith(), packageName);
     }
 
     private native void nativeInit();
     private native void nativeDestroy(long nativeTabAndroid);
     private native void nativeInitWebContents(long nativeTabAndroid, boolean incognito,
             ContentViewCore contentViewCore, TabWebContentsDelegateAndroid delegate,
             ContextMenuPopulator contextMenuPopulator);
+    private native void nativeUpdateDelegates(long nativeTabAndroid,
+            TabWebContentsDelegateAndroid delegate, ContextMenuPopulator contextMenuPopulator);
     private native void nativeDestroyWebContents(long nativeTabAndroid, boolean deleteNative);
     private native Profile nativeGetProfileAndroid(long nativeTabAndroid);
     private native int nativeLoadUrl(long nativeTabAndroid, String url, String extraHeaders,
             byte[] postData, int transition, String referrerUrl, int referrerPolicy,
             boolean isRendererInitiated, boolean shoulReplaceCurrentEntry,
             long intentReceivedTimestamp, boolean hasUserGesture);
     private native void nativeSetActiveNavigationEntryTitleForUrl(long nativeTabAndroid, String url,
             String title);
     private native boolean nativePrint(long nativeTabAndroid);
     private native Bitmap nativeGetFavicon(long nativeTabAndroid);
     private native void nativeCreateHistoricalTab(long nativeTabAndroid);
     private native void nativeUpdateTopControlsState(
             long nativeTabAndroid, int constraints, int current, boolean animate);
     private native void nativeLoadOriginalImage(long nativeTabAndroid);
     private native long nativeGetBookmarkId(long nativeTabAndroid, boolean onlyEditable);
     private native boolean nativeHasOfflineCopy(long nativeTabAndroid);
     private native boolean nativeIsOfflinePage(long nativeTabAndroid);
     private native String nativeGetOfflinePageOriginalUrl(long nativeTabAndroid);
     private native void nativeSetInterceptNavigationDelegate(long nativeTabAndroid,
             InterceptNavigationDelegate delegate);
     private native void nativeAttachToTabContentManager(long nativeTabAndroid,
             TabContentManager tabContentManager);
     private native void nativeAttachOverlayContentViewCore(long nativeTabAndroid,
             ContentViewCore content, boolean visible);
     private native void nativeDetachOverlayContentViewCore(long nativeTabAndroid,
             ContentViewCore content);
     private native boolean nativeHasPrerenderedUrl(long nativeTabAndroid, String url);
 }