Port passing closure tests for cr.ui framework to browser tests.

Port passing closure tests for cr.ui framework to browser tests.  This CL deals with porting closure tests that require minimal formatting changes to run as browser tests.

BUG=249104
TEST=WebUIResourceBrowserTest

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207770

[kevers, 2013-06-20 14:04:15]

Erik and Dan,

Can you please take a look at this CL.

[arv (Not doing code reviews), 2013-06-20 14:26:24]

https://chromiumcodereview.appspot.com/17315020/diff/1/chrome/test/data/webui...
File chrome/test/data/webui/webui_resource_test.js (right):

https://chromiumcodereview.appspot.com/17315020/diff/1/chrome/test/data/webui...
chrome/test/data/webui/webui_resource_test.js:77: */
This is generally not a useful assertion function since exceptions already fail
the test.

assertNotThrows(f)

can be replaced by

f()

https://chromiumcodereview.appspot.com/17315020/diff/1/chrome/test/data/webui...
chrome/test/data/webui/webui_resource_test.js:92: * @param {Array.<Object>}
expected The expected result.
{Array} since the array can contain any value

https://chromiumcodereview.appspot.com/17315020/diff/1/chrome/test/data/webui...
chrome/test/data/webui/webui_resource_test.js:97: var v2 =
Array.prototype.concat.call(observed);
not concat... use slice. slice is generic, concat is not

[kevers, 2013-06-20 14:59:27]

https://chromiumcodereview.appspot.com/17315020/diff/1/chrome/test/data/webui...
File chrome/test/data/webui/webui_resource_test.js (right):

https://chromiumcodereview.appspot.com/17315020/diff/1/chrome/test/data/webui...
chrome/test/data/webui/webui_resource_test.js:77: */
On 2013/06/20 14:26:24, arv wrote:
> This is generally not a useful assertion function since exceptions already
fail
> the test.
> 
> assertNotThrows(f)
> 
> can be replaced by
> 
> f()

Removed.

https://chromiumcodereview.appspot.com/17315020/diff/1/chrome/test/data/webui...
chrome/test/data/webui/webui_resource_test.js:92: * @param {Array.<Object>}
expected The expected result.
On 2013/06/20 14:26:24, arv wrote:
> {Array} since the array can contain any value

Done.

https://chromiumcodereview.appspot.com/17315020/diff/1/chrome/test/data/webui...
chrome/test/data/webui/webui_resource_test.js:97: var v2 =
Array.prototype.concat.call(observed);
On 2013/06/20 14:26:24, arv wrote:
> not concat... use slice. slice is generic, concat is not

Done.

[arv (Not doing code reviews), 2013-06-20 15:17:27]

LGTM

[Dan Beam, 2013-06-20 17:57:45]

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
File chrome/test/data/webui/event_target_test.html (right):

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
chrome/test/data/webui/event_target_test.html:9: var EventTarget;
nit: /** @const */

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
File chrome/test/data/webui/position_util_test.html (left):

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
chrome/test/data/webui/position_util_test.html:51: var pr = new
goog.testing.PropertyReplacer;
propertyreplacer is fancier :(

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
File chrome/test/data/webui/webui_resource_browsertest.cc (right):

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
chrome/test/data/webui/webui_resource_browsertest.cc:100:
RunTest(base::FilePath(FILE_PATH_LITERAL("grid_test.html")));
this is kind of tedious but i don't have a better suggestion :(

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
File chrome/test/data/webui/webui_resource_test.js (right):

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
chrome/test/data/webui/webui_resource_test.js:85: if (v1[i] !== v2[i]) {
what if v1[i] is a (non-null) object or array?  should probably recurse, no?

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
chrome/test/data/webui/webui_resource_test.js:93: '\n  Expected: ' + v1;
nit:
var message =
    ['Assertion Failed', 'Observed: ' + v2, 'Expected: ' + v1].join('\n  ');

[arv (Not doing code reviews), 2013-06-20 18:35:33]

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
File chrome/test/data/webui/webui_resource_test.js (right):

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
chrome/test/data/webui/webui_resource_test.js:85: if (v1[i] !== v2[i]) {
On 2013/06/20 17:57:46, Dan Beam wrote:
> what if v1[i] is a (non-null) object or array?  should probably recurse, no?

We should not recurse. Recursion should be done in an assertDeepEqual.

[kevers, 2013-06-20 18:41:37]

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
File chrome/test/data/webui/event_target_test.html (right):

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
chrome/test/data/webui/event_target_test.html:9: var EventTarget;
On 2013/06/20 17:57:46, Dan Beam wrote:
> nit: /** @const */

Done.

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
File chrome/test/data/webui/position_util_test.html (left):

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
chrome/test/data/webui/position_util_test.html:51: var pr = new
goog.testing.PropertyReplacer;
On 2013/06/20 17:57:46, Dan Beam wrote:
> propertyreplacer is fancier :(

Can certainly add it if you'd like.  The last of the failing tests
(link_controller_tests) also makes use of property replacer, and in a less
trivial use case.  For this particular test, it seems unnecessary.

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
File chrome/test/data/webui/webui_resource_test.js (right):

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
chrome/test/data/webui/webui_resource_test.js:93: '\n  Expected: ' + v1;
On 2013/06/20 17:57:46, Dan Beam wrote:
> nit:
> var message =
>     ['Assertion Failed', 'Observed: ' + v2, 'Expected: ' + v1].join('\n  ');

Done.

[Dan Beam, 2013-06-20 18:42:20]

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
File chrome/test/data/webui/position_util_test.html (left):

https://chromiumcodereview.appspot.com/17315020/diff/4001/chrome/test/data/we...
chrome/test/data/webui/position_util_test.html:51: var pr = new
goog.testing.PropertyReplacer;
On 2013/06/20 18:41:37, kevers wrote:
> On 2013/06/20 17:57:46, Dan Beam wrote:
> > propertyreplacer is fancier :(
> 
> Can certainly add it if you'd like.  The last of the failing tests
> (link_controller_tests) also makes use of property replacer, and in a less
> trivial use case.  For this particular test, it seems unnecessary.

whatever you'd like, i've just found it handy in the past...

[Dan Beam, 2013-06-20 18:43:14]

lgtm but i don't really see the point to having an assertArrayEquals() when you
could just use assertDeepEquals() for this...

[commit-bot: I haz the power, 2013-06-20 19:49:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/17315020/6002

[commit-bot: I haz the power, 2013-06-21 09:42:39]

Change committed as 207770