Issue 17315016: Use base::RunLoop instead of directly using MessageLoop in Drive related code.

Issue 17315016: Use base::RunLoop instead of directly using MessageLoop in Drive related code. (Closed)

Created:
7 years, 6 months ago by kinaba

Modified:
7 years, 6 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use base::RunLoop instead of directly using MessageLoop in Drive related code. BUG=247559 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207573

Patch Set 2 : Remove unneeded #include #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1036 lines, -857 lines)			Patch
M	chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc	View	1	6 chunks	+51 lines, -44 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_url_request_job_unittest.cc	View	1	14 chunks	+23 lines, -20 lines	0 comments	Download
M	chrome/browser/google_apis/base_requests_server_unittest.cc	View		3 chunks	+33 lines, -29 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests_unittest.cc	View	1	29 chunks	+425 lines, -345 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_requests_unittest.cc	View	1	33 chunks	+489 lines, -405 lines	0 comments	Download
M	chrome/browser/google_apis/test_util.h	View		3 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/google_apis/test_util.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

hashimoto

lgtm https://codereview.chromium.org/17315016/diff/2001/chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc File chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc (right): https://codereview.chromium.org/17315016/diff/2001/chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc#newcode12 chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc:12: #include "base/rand_util.h" nit: Do we need to include ...

7 years, 6 months ago (2013-06-20 04:45:42 UTC) #2

kinaba

https://codereview.chromium.org/17315016/diff/2001/chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc File chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc (right): https://codereview.chromium.org/17315016/diff/2001/chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc#newcode12 chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc:12: #include "base/rand_util.h" On 2013/06/20 04:45:42, hashimoto wrote: > nit: ...

7 years, 6 months ago (2013-06-20 04:58:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17315016/7001

7 years, 6 months ago (2013-06-20 14:45:57 UTC) #5

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 6 months ago (2013-06-20 16:18:23 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17315016/7001

7 years, 6 months ago (2013-06-20 17:17:18 UTC) #7

Message was sent while issue was closed.

Change committed as 207573

Expand Messages | Collapse Messages