the patcher process runs inside of a job

Run the patcher process inside of a job to avoid leaving child
processes around when the browser process terminates.

BUG=245318
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208640

[Sorin Jianu, 2013-06-22 04:47:36]

I am trying to run the external patcher process (in this case the Chrome
setup.exe) in a Windows job object so that the child is terminated when the
browser process dies.

The code works nicely when the browser crashes.

When the user is closing the browser, unfortunately the browser process did not
exit immediately is it happens to be blocked waiting on the patcher to finish
the patching. I am not sure what the browser shutdown sequence is. Eventually, a
timeout kicks in, the browser exits and the job kills the patcher as expected.

A better idea would be to get a notification in the ComponentUpdaterService that
the browser is shutting down, maintain a handle of the job in the service, and
close the job handle to force the termination of the patcher.

What we have now is better than nothing though.

[cpu_(ooo_6.6-7.5), 2013-06-25 19:01:35]

lgtm

[robertshield, 2013-06-25 19:07:49]

lgtm

[commit-bot: I haz the power, 2013-06-25 22:33:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sorin@chromium.org/17314017/1

[commit-bot: I haz the power, 2013-06-26 05:54:12]

Change committed as 208640