Issue 17314008: Switch accept button text from "Submit" to "Continue".

Issue 17314008: Switch accept button text from "Submit" to "Continue". (Closed)

Created:
7 years, 6 months ago by ahutter

Modified:
7 years, 6 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switch accept button text from "Submit" to "Continue". BUG=252317 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207769

Patch Set 2 : Fixing TOS text #

Total comments: 2

Patch Set 3 : Evan's review #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	chrome/app/generated_resources.grd	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

The bug doesn't provide any context or background on the decision. Was there sign-off from ...

7 years, 6 months ago (2013-06-20 18:23:23 UTC) #2

Evan Stade

ainslie@ said "Cool, works for me". https://codereview.chromium.org/17314008/diff/3001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (left): https://codereview.chromium.org/17314008/diff/3001/chrome/app/generated_resources.grd#oldcode10835 chrome/app/generated_resources.grd:10835: <message name="IDS_AUTOFILL_DIALOG_CONTINUE_BUTTON" desc="Button ...

7 years, 6 months ago (2013-06-20 19:26:05 UTC) #3

ahutter

Thanks for the suggestion :) https://codereview.chromium.org/17314008/diff/3001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (left): https://codereview.chromium.org/17314008/diff/3001/chrome/app/generated_resources.grd#oldcode10835 chrome/app/generated_resources.grd:10835: <message name="IDS_AUTOFILL_DIALOG_CONTINUE_BUTTON" desc="Button text ...

7 years, 6 months ago (2013-06-20 19:45:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahutter@chromium.org/17314008/8001

7 years, 6 months ago (2013-06-20 20:04:11 UTC) #6

Message was sent while issue was closed.

Change committed as 207769

Expand Messages | Collapse Messages