Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 17294005: Clear the shader disk cache whenver we receive REMOVE_CACHE. (Closed)

Created:
7 years, 6 months ago by dsinclair
Modified:
7 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, markusheintz_
Visibility:
Public.

Description

Clear the shader disk cache whenver we receive REMOVE_CACHE. The shader disk cache was only cleared if we recieved a REMOVE_SHADER_CACHE or a REMOVE_CACHED_DATA. The REMOVE_CACHED_DATA was only plumbed into the clearing from the WebUI. There are a few places that expect the cache to be fully cleared using REMOVE_CACHE. This CL removes the extra REMOVE_SHADER_CACHE flag and always clears the shader cache if the user clears their cache. BUG=249295 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206917

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover.h View 2 chunks +0 lines, -3 lines 1 comment Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dsinclair
bauerb, PTAL.
7 years, 6 months ago (2013-06-17 18:55:23 UTC) #1
Bernhard Bauer
lgtm
7 years, 6 months ago (2013-06-17 21:39:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/17294005/1
7 years, 6 months ago (2013-06-18 01:23:56 UTC) #3
commit-bot: I haz the power
Change committed as 206917
7 years, 6 months ago (2013-06-18 08:20:10 UTC) #4
Pam (message me for reviews)
https://chromiumcodereview.appspot.com/17294005/diff/1/chrome/browser/browsing_data/browsing_data_remover.h File chrome/browser/browsing_data/browsing_data_remover.h (right): https://chromiumcodereview.appspot.com/17294005/diff/1/chrome/browser/browsing_data/browsing_data_remover.h#newcode91 chrome/browser/browsing_data/browsing_data_remover.h:91: // storage, webSQL, shader, and plugin data. This says ...
7 years, 6 months ago (2013-06-18 08:28:52 UTC) #5
dsinclair
7 years, 6 months ago (2013-06-18 15:39:42 UTC) #6
Message was sent while issue was closed.
On 2013/06/18 08:28:52, Pam - also send IM for reviews wrote:
>
https://chromiumcodereview.appspot.com/17294005/diff/1/chrome/browser/browsin...
> File chrome/browser/browsing_data/browsing_data_remover.h (right):
> 
>
https://chromiumcodereview.appspot.com/17294005/diff/1/chrome/browser/browsin...
> chrome/browser/browsing_data/browsing_data_remover.h:91: // storage, webSQL,
> shader, and plugin data.
> This says "shader" but doesn't include the shader cache.

CL sent to fixup the comment. Thanks for the pointer.

Powered by Google App Engine
This is Rietveld 408576698