Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17291008: Added tests to verify back/forward button logic works as expected when instant extended enabled. (Closed)

Created:
7 years, 6 months ago by kmadhusu
Modified:
7 years, 6 months ago
Reviewers:
Jered
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Visibility:
Public.

Description

Added tests to verify back/forward button logic works as expected when instant extended enabled. BUG=246685 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208032

Patch Set 1 : '' #

Patch Set 2 : Disable InstantExtendedTest.NavigateBackToNTP on Mac. #

Total comments: 2

Patch Set 3 : Addressed comment #

Patch Set 4 : Disable tests on Mac #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -0 lines) Patch
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 2 3 4 5 1 chunk +178 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kmadhusu
7 years, 6 months ago (2013-06-18 01:09:49 UTC) #1
Jered
https://codereview.chromium.org/17291008/diff/14001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc File chrome/browser/ui/search/instant_extended_interactive_uitest.cc (right): https://codereview.chromium.org/17291008/diff/14001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc#newcode3006 chrome/browser/ui/search/instant_extended_interactive_uitest.cc:3006: // Commit the search by pressing 'Enter'. Why do ...
7 years, 6 months ago (2013-06-19 22:44:55 UTC) #2
kmadhusu
Addressed comment. PTAL. Thanks. https://codereview.chromium.org/17291008/diff/14001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc File chrome/browser/ui/search/instant_extended_interactive_uitest.cc (right): https://codereview.chromium.org/17291008/diff/14001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc#newcode3006 chrome/browser/ui/search/instant_extended_interactive_uitest.cc:3006: // Commit the search by ...
7 years, 6 months ago (2013-06-21 17:00:59 UTC) #3
Jered
On 2013/06/21 17:00:59, kmadhusu wrote: > Addressed comment. PTAL. > > Thanks. > > https://codereview.chromium.org/17291008/diff/14001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc ...
7 years, 6 months ago (2013-06-21 18:04:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/17291008/40001
7 years, 6 months ago (2013-06-21 18:56:42 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=141618
7 years, 6 months ago (2013-06-21 19:54:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/17291008/61001
7 years, 6 months ago (2013-06-21 20:28:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/17291008/61001
7 years, 6 months ago (2013-06-22 01:29:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/17291008/61001
7 years, 6 months ago (2013-06-22 02:38:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/17291008/61001
7 years, 6 months ago (2013-06-22 03:04:37 UTC) #10
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 14:11:34 UTC) #11
Message was sent while issue was closed. 
Change committed as 208032

Powered by Google App Engine
This is Rietveld 408576698