Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: media/blink/cdm_result_promise.h

Issue 1729063003: media: Reject pending CDM promise during destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/cdm_result_promise.h
diff --git a/media/blink/cdm_result_promise.h b/media/blink/cdm_result_promise.h
index 179654eae88a36ef7228b1f08c495bbc11f25cb4..3a1816333677be06554c036c3811df3c08c7a115 100644
--- a/media/blink/cdm_result_promise.h
+++ b/media/blink/cdm_result_promise.h
@@ -24,7 +24,7 @@ namespace media {
// If constructed with a |uma_name|, CdmResultPromise will report the promise
// result (success or rejection code) to UMA.
template <typename... T>
-class CdmResultPromise : public media::CdmPromiseTemplate<T...> {
+class CdmResultPromise : public CdmPromiseTemplate<T...> {
public:
CdmResultPromise(const blink::WebContentDecryptionModuleResult& result,
const std::string& uma_name);
@@ -32,12 +32,14 @@ class CdmResultPromise : public media::CdmPromiseTemplate<T...> {
// CdmPromiseTemplate<T> implementation.
void resolve(const T&... result) override;
- void reject(media::MediaKeys::Exception exception_code,
+ void reject(MediaKeys::Exception exception_code,
uint32_t system_code,
const std::string& error_message) override;
private:
- using media::CdmPromiseTemplate<T...>::MarkPromiseSettled;
+ using CdmPromiseTemplate<T...>::IsPromiseSettled;
+ using CdmPromiseTemplate<T...>::MarkPromiseSettled;
+ using CdmPromiseTemplate<T...>::RejectPromiseOnDestruction;
blink::WebContentDecryptionModuleResult web_cdm_result_;
@@ -56,6 +58,11 @@ CdmResultPromise<T...>::CdmResultPromise(
template <typename... T>
CdmResultPromise<T...>::~CdmResultPromise() {
+ if (IsPromiseSettled())
+ return;
+
+ DCHECK(!web_cdm_result_.isCompleted());
+ RejectPromiseOnDestruction();
}
// "inline" is needed to prevent multiple definition error.
@@ -68,7 +75,7 @@ inline void CdmResultPromise<>::resolve() {
}
template <typename... T>
-void CdmResultPromise<T...>::reject(media::MediaKeys::Exception exception_code,
+void CdmResultPromise<T...>::reject(MediaKeys::Exception exception_code,
uint32_t system_code,
const std::string& error_message) {
MarkPromiseSettled();

Powered by Google App Engine
This is Rietveld 408576698