Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1728063002: Revert of mojo: Delay ApplicationTestBase shell disconnection. (Closed)

Created:
4 years, 10 months ago by xhwang
Modified:
4 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mojo: Delay ApplicationTestBase shell disconnection. (patchset #3 id:60001 of https://chromiumcodereview.appspot.com/1709173002/ ) Reason for revert: Revert this for now to investigate crash on Windows. Original issue's description: > mojo: Delay ApplicationTestBase shell disconnection. > > BUG=587523 > TEST=Reenable tests. > > Committed: https://crrev.com/74cb68fa1c313c885c6022eea11ef6855d9ca0da > Cr-Commit-Position: refs/heads/master@{#377068} TBR=rockot@chromium.org,msw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587523 Committed: https://crrev.com/4499ff5785c7926f705d5abbdb46f20ba2e78f09 Cr-Commit-Position: refs/heads/master@{#377160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M mojo/shell/public/cpp/application_test_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/public/cpp/lib/application_test_base.cc View 3 chunks +9 lines, -13 lines 0 comments Download
M mojo/tools/data/apptests View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
xhwang
Created Revert of mojo: Delay ApplicationTestBase shell disconnection.
4 years, 10 months ago (2016-02-24 00:46:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728063002/1
4 years, 10 months ago (2016-02-24 00:50:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 00:56:06 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 00:58:17 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4499ff5785c7926f705d5abbdb46f20ba2e78f09
Cr-Commit-Position: refs/heads/master@{#377160}

Powered by Google App Engine
This is Rietveld 408576698