[Herb] Add metrics to track button usage

tools/metrics/actions/actions.xml

Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index 03d73bd414cef53ccd82709b785cab653a46edc0..f174e684dea1663b5ac44c6b88f83b88cdd58bd3 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -2521,6 +2521,18 @@ should be able to be added at any place in this file.
   <obsolete>Deprecated as of 11/2015.</obsolete>
 </action>
 
+<action name="CustomTabs.CloseButtonClicked">
+  <owner>dfalcantara@chromium.org</owner>
+  <description>Close button of the CustomTabActivity was clicked.</description>
+</action>
+
+<action name="CustomTabs.SystemBackFinishedApp">
+  <owner>dfalcantara@chromium.org</owner>
+  <description>
+    CustomTabActivity closed because user hit the 'back' button.
+  </description>
+</action>
+
 <action name="CustomTabsCustomActionButtonClick">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of the metric.</description>
@@ -3623,6 +3635,18 @@ should be able to be added at any place in this file.
   <description>User saw the UwS (harmful) interstitial.</description>
 </action>
 
+<action name="Herb.OpenInChromeActionButtonClicked">

[Ilya Sherman, 2016/02/24 23:01:02]

Are you sure that you want to use "Herb" as the top-level name for this metric? 
It's a pretty opaque name.

[gone, 2016/02/25 01:30:21]

Swapped over to "TaskManagement"... it's about as accurate as I can get for the
nebulous proposal that I'm working with.

+  <owner>dfalcantara@chromium.org</owner>
+  <description>
+    User hit the &quot;Open in Chrome&quot; action button.
+  </description>
+</action>
+
+<action name="Herb.ReturnButtonClicked">
+  <owner>dfalcantara@chromium.org</owner>
+  <description>User hit the &quot;X&quot; button to close the tab.</description>

[Ilya Sherman, 2016/02/24 23:01:02]

How does the "return" button differ from a "close" button?

[gone, 2016/02/25 01:30:21]

The return button is an explicit "close this tab and return to the previous app"
button that appears to the left of the Omnibox, and only in two of the
prototypes on phones.  The regular close button would be something like the the
X in the tab switcher or on the right of the tab in tablet mode, neither of
which sends the user back to the previous app AIUI.

+</action>
+
 <action name="HiliteColor">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>
@@ -12970,9 +12994,41 @@ should be able to be added at any place in this file.
   <description>Please enter the description of this user action.</description>
 </action>
 
+<action name="SystemBack.MinimizedAppNoTabClosed">
+  <owner>dfalcantara@chromium.org</owner>
+  <description>
+    Activity was minimized because user hit the system back button.
+  </description>
+</action>
+
+<action name="SystemBack.MinimizedAppTabClosed">
+  <owner>dfalcantara@chromium.org</owner>
+  <description>
+    Activity was minimized and foreground tab was closed because user hit the
+    system back button.
+  </description>
+</action>
+
+<action name="SystemBack.TabClosed">
+  <owner>dfalcantara@chromium.org</owner>
+  <description>
+    Foreground tab was closed because the user hit the system back button.

[Ilya Sherman, 2016/02/24 23:01:02]

Is this recorded in the case that MinimizedAppTabClosed is recorded?  Or are
they mutually exclusive?  These don't really seem like distinct user actions --
the user performs the same action regardless.  I'd recommend using an enumerated
histogram to track these.

[gone, 2016/02/25 01:30:21]

Yeah, swapped over.

+  </description>
+</action>
+
+<action name="SystemBack.TabIsNull">
+  <owner>dfalcantara@chromium.org</owner>
+  <description>
+    Error condition -- the user hit back while there was no tab to close.
+  </description>
+</action>
+
 <action name="SystemBackForNavigation">
-  <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
-  <description>Please enter the description of this user action.</description>
+  <owner>dfalcantara@chromium.org</owner>
+  <description>
+    The user navigated backward in the tab's history using the system back
+    button.
+  </description>
 </action>
 
 <action name="TabContextMenu_BookmarkAllTabs">