Issue 17277004: Split list of referenced libraries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17277004: Split list of referenced libraries (Closed)

Created:
7 years, 6 months ago by Brian Wilkerson

Modified:
7 years, 6 months ago

Reviewers:
jwren

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Split the list of referenced libraries stored in the cache into two separate lists, one for imports and one for exports. I expected to see performance improvements because of using cached data in the library resolver, but couldn't confirm. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=24193

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+393 lines, -218 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/cache/DartEntry.java	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/cache/DartEntryImpl.java	View	1	12 chunks	+50 lines, -22 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java	View	1	11 chunks	+127 lines, -16 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/DelegatingAnalysisContextImpl.java	View	1	2 chunks	+18 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/InstrumentedAnalysisContextImpl.java	View	1	2 chunks	+22 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/InternalAnalysisContext.java	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/Library.java	View	1	8 chunks	+35 lines, -52 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryResolver.java	View	1	2 chunks	+87 lines, -84 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/cache/DartEntryImplTest.java	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/LibraryTest.java	View	1	4 chunks	+20 lines, -40 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

7 years, 6 months ago (2013-06-19 16:51:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r24193 (presubmit successful).

Expand Messages | Collapse Messages