android_webview/browser/browser_view_renderer.h - Issue 17274013: [Android WebView] Clamp Bitmap size to max. dimensions when drawing into a Canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/browser_view_renderer.h

Issue 17274013: [Android WebView] Clamp Bitmap size to max. dimensions when drawing into a Canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: joth comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/browser_view_renderer.h

diff --git a/android_webview/browser/browser_view_renderer.h b/android_webview/browser/browser_view_renderer.h

index 52f917e9345c653f15fa53e4a78b6d3899d5ffcc..9d7a46b11eedca24430b258039f16c4969b146e9 100644

--- a/android_webview/browser/browser_view_renderer.h

+++ b/android_webview/browser/browser_view_renderer.h

@@ -54,7 +54,8 @@ class BrowserViewRenderer {

virtual base::android::ScopedJavaLocalRef<jobject> CreateBitmap(

JNIEnv* env,

int width,

- int height) = 0;

+ int height,

+ const base::android::JavaRef<jobject>& jcanvas) = 0;

// Draws the provided Java Bitmap into the provided Java Canvas.

virtual void DrawBitmapIntoCanvas(

« no previous file with comments | « no previous file | android_webview/browser/in_process_view_renderer.cc » ('j') | no next file with comments »