Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/profile_resetter/profile_resetter_unittest.cc

Issue 17274006: Reset profile: reset cookies and site data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profile_resetter/profile_resetter_test_base.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profile_resetter/profile_resetter_unittest.cc
diff --git a/chrome/browser/profile_resetter/profile_resetter_unittest.cc b/chrome/browser/profile_resetter/profile_resetter_unittest.cc
index 8127d75e676c66c4eec8c2e3da3c941c6417606e..556da08e2c2c884209db9ede777e33a1f060592a 100644
--- a/chrome/browser/profile_resetter/profile_resetter_unittest.cc
+++ b/chrome/browser/profile_resetter/profile_resetter_unittest.cc
@@ -4,11 +4,11 @@
#include "chrome/browser/profile_resetter/profile_resetter.h"
-#include "base/bind.h"
#include "base/prefs/pref_service.h"
#include "chrome/browser/extensions/extension_service_unittest.h"
#include "chrome/browser/extensions/tab_helper.h"
#include "chrome/browser/prefs/session_startup_pref.h"
+#include "chrome/browser/profile_resetter/profile_resetter_test_base.h"
#include "chrome/browser/search_engines/template_url_service_test_util.h"
#include "chrome/browser/themes/theme_service.h"
#include "chrome/browser/themes/theme_service_factory.h"
@@ -17,52 +17,14 @@
#include "chrome/common/extensions/extension_manifest_constants.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/browser_with_test_window_test.h"
-#include "chrome/test/base/testing_profile.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/test/test_utils.h"
-#include "testing/gmock/include/gmock/gmock.h"
+
namespace {
using extensions::Extension;
using extensions::Manifest;
-class MockObject {
- public:
- void RunLoop() {
- EXPECT_CALL(*this, Callback());
- runner_ = new content::MessageLoopRunner;
- runner_->Run();
- }
-
- void StopLoop() {
- DCHECK(runner_.get());
- Callback();
- runner_->Quit();
- }
-
- private:
- MOCK_METHOD0(Callback, void(void));
-
- scoped_refptr<content::MessageLoopRunner> runner_;
-};
-
-class ProfileResetterTestBase {
- public:
- ProfileResetterTestBase();
- ~ProfileResetterTestBase();
- protected:
- testing::StrictMock<MockObject> mock_object_;
- scoped_ptr<ProfileResetter> resetter_;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(ProfileResetterTestBase);
-};
-
-ProfileResetterTestBase::ProfileResetterTestBase() {}
-
-ProfileResetterTestBase::~ProfileResetterTestBase() {}
-
class ProfileResetterTest : public testing::Test,
public ProfileResetterTestBase {
protected:
@@ -95,9 +57,6 @@ void ExtensionsResetTest::SetUp() {
resetter_.reset(new ProfileResetter(profile_.get()));
}
-// Returns a barebones test Extension object with the specified |name|. The
-// returned extension will include background permission iff
-// |background_permission| is true.
scoped_refptr<Extension> CreateExtension(const std::string& name,
const base::FilePath& path,
Manifest::Location location,
@@ -140,10 +99,17 @@ content::WebContents* PinnedTabsResetTest::CreateWebContents() {
/********************* Tests *********************/
TEST_F(ProfileResetterTest, ResetDefaultSearchEngine) {
+ PrefService* prefs = test_util_.profile()->GetPrefs();
+ DCHECK(prefs);
+ prefs->SetString(prefs::kLastPromptedGoogleURL, "http://www.foo.com/");
+
resetter_->Reset(
ProfileResetter::DEFAULT_SEARCH_ENGINE,
- base::Bind(&MockObject::StopLoop, base::Unretained(&mock_object_)));
+ base::Bind(&ProfileResetterMockObject::StopLoop,
+ base::Unretained(&mock_object_)));
mock_object_.RunLoop();
+
+ EXPECT_EQ("", prefs->GetString(prefs::kLastPromptedGoogleURL));
}
TEST_F(ProfileResetterTest, ResetHomepage) {
@@ -155,7 +121,8 @@ TEST_F(ProfileResetterTest, ResetHomepage) {
resetter_->Reset(
ProfileResetter::HOMEPAGE,
- base::Bind(&MockObject::StopLoop, base::Unretained(&mock_object_)));
+ base::Bind(&ProfileResetterMockObject::StopLoop,
+ base::Unretained(&mock_object_)));
mock_object_.RunLoop();
EXPECT_TRUE(prefs->GetBoolean(prefs::kHomePageIsNewTabPage));
@@ -166,14 +133,8 @@ TEST_F(ProfileResetterTest, ResetHomepage) {
TEST_F(ProfileResetterTest, ResetContentSettings) {
resetter_->Reset(
ProfileResetter::CONTENT_SETTINGS,
- base::Bind(&MockObject::StopLoop, base::Unretained(&mock_object_)));
- mock_object_.RunLoop();
-}
-
-TEST_F(ProfileResetterTest, ResetCookiesAndSiteData) {
- resetter_->Reset(
- ProfileResetter::COOKIES_AND_SITE_DATA,
- base::Bind(&MockObject::StopLoop, base::Unretained(&mock_object_)));
+ base::Bind(&ProfileResetterMockObject::StopLoop,
+ base::Unretained(&mock_object_)));
mock_object_.RunLoop();
}
@@ -216,7 +177,8 @@ TEST_F(ExtensionsResetTest, ResetExtensionsByDisabling) {
resetter_->Reset(
ProfileResetter::EXTENSIONS,
- base::Bind(&MockObject::StopLoop, base::Unretained(&mock_object_)));
+ base::Bind(&ProfileResetterMockObject::StopLoop,
+ base::Unretained(&mock_object_)));
mock_object_.RunLoop();
EXPECT_EQ(2u, service_->extensions()->size());
@@ -236,7 +198,8 @@ TEST_F(ProfileResetterTest, ResetStartPage) {
resetter_->Reset(
ProfileResetter::STARTUP_PAGES,
- base::Bind(&MockObject::StopLoop, base::Unretained(&mock_object_)));
+ base::Bind(&ProfileResetterMockObject::StopLoop,
+ base::Unretained(&mock_object_)));
mock_object_.RunLoop();
startup_pref = SessionStartupPref::GetStartupPref(prefs);
@@ -250,20 +213,20 @@ TEST_F(PinnedTabsResetTest, ResetPinnedTabs) {
base::FilePath(FILE_PATH_LITERAL("//nonexistent")),
Manifest::INVALID_LOCATION,
false);
- content::WebContents* contents1 = CreateWebContents();
- extensions::TabHelper::CreateForWebContents(contents1);
- extensions::TabHelper::FromWebContents(contents1)->
+ scoped_ptr<content::WebContents> contents1(CreateWebContents());
+ extensions::TabHelper::CreateForWebContents(contents1.get());
+ extensions::TabHelper::FromWebContents(contents1.get())->
SetExtensionApp(extension_app.get());
- content::WebContents* contents2 = CreateWebContents();
- content::WebContents* contents3 = CreateWebContents();
- content::WebContents* contents4 = CreateWebContents();
+ scoped_ptr<content::WebContents> contents2(CreateWebContents());
+ scoped_ptr<content::WebContents> contents3(CreateWebContents());
+ scoped_ptr<content::WebContents> contents4(CreateWebContents());
TabStripModel* tab_strip_model = browser()->tab_strip_model();
- tab_strip_model->AppendWebContents(contents4, true);
- tab_strip_model->AppendWebContents(contents3, true);
- tab_strip_model->AppendWebContents(contents2, true);
+ tab_strip_model->AppendWebContents(contents4.get(), true);
+ tab_strip_model->AppendWebContents(contents3.get(), true);
+ tab_strip_model->AppendWebContents(contents2.get(), true);
tab_strip_model->SetTabPinned(2, true);
- tab_strip_model->AppendWebContents(contents1, true);
+ tab_strip_model->AppendWebContents(contents1.get(), true);
tab_strip_model->SetTabPinned(3, true);
EXPECT_EQ(contents2, tab_strip_model->GetWebContentsAt(0));
@@ -274,7 +237,8 @@ TEST_F(PinnedTabsResetTest, ResetPinnedTabs) {
resetter_->Reset(
ProfileResetter::PINNED_TABS,
- base::Bind(&MockObject::StopLoop, base::Unretained(&mock_object_)));
+ base::Bind(&ProfileResetterMockObject::StopLoop,
+ base::Unretained(&mock_object_)));
mock_object_.RunLoop();
EXPECT_EQ(contents1, tab_strip_model->GetWebContentsAt(0));
@@ -288,7 +252,8 @@ TEST_F(ProfileResetterTest, ResetFewFlags) {
// mock_object_ is a StrictMock, so we verify that it is called only once.
resetter_->Reset(
ProfileResetter::DEFAULT_SEARCH_ENGINE | ProfileResetter::HOMEPAGE,
- base::Bind(&MockObject::StopLoop, base::Unretained(&mock_object_)));
+ base::Bind(&ProfileResetterMockObject::StopLoop,
+ base::Unretained(&mock_object_)));
mock_object_.RunLoop();
}
« no previous file with comments | « chrome/browser/profile_resetter/profile_resetter_test_base.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698