Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 17272002: Make git cl smarter about subcommands typos. (Closed)

Created:
7 years, 6 months ago by M-A Ruel
Modified:
7 years, 6 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Make git cl smarter about subcommands typos. Look for either a unique prefix or for an approximation of the shortest Levenshtein distance. So all of these will resolve to 'git cl upload': git cl upl git cl uplaod These won't resolve: git cl up # it shares prefix with 'upstream' git cl uplao # not similar enough Also align help against longest command instead of hard coded '10'. The help page was distorded. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=206820

Patch Set 1 #

Patch Set 2 : cleaner #

Patch Set 3 : Use 0.3 instead of 0.1 as minimum difference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -5 lines) Patch
M git_cl.py View 1 2 5 chunks +48 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
M-A Ruel
I wanted to do this for a while. Today was the day.
7 years, 6 months ago (2013-06-17 13:15:57 UTC) #1
iannucci
On 2013/06/17 13:15:57, Marc-Antoine Ruel wrote: > I wanted to do this for a while. ...
7 years, 6 months ago (2013-06-17 19:41:25 UTC) #2
M-A Ruel
On 2013/06/17 19:41:25, iannucci wrote: > On 2013/06/17 13:15:57, Marc-Antoine Ruel wrote: > > I ...
7 years, 6 months ago (2013-06-17 19:43:48 UTC) #3
M-A Ruel
On 2013/06/17 19:43:48, Marc-Antoine Ruel wrote: > On 2013/06/17 19:41:25, iannucci wrote: > > On ...
7 years, 6 months ago (2013-06-17 22:01:16 UTC) #4
iannucci
lgtm
7 years, 6 months ago (2013-06-17 22:47:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/17272002/7001
7 years, 6 months ago (2013-06-17 22:50:44 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-17 22:52:25 UTC) #7
Message was sent while issue was closed.
Change committed as 206820

Powered by Google App Engine
This is Rietveld 408576698