Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 17266002: Replace Chinese Input with migration code. (Closed)

Created:
7 years, 6 months ago by Seigo Nonaka
Modified:
7 years, 6 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Replace Chinese Input with migration code. With this CL, legacy ibus pinyin input will not be used and new IME extension API based one is used instead. The changes for unit tests are mostly changing hard-coded old input method id to new input method id. BUG=240659 TEST=ran all tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207239

Patch Set 1 : #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -53 lines) Patch
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 1 9 chunks +16 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 3 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 13 chunks +49 lines, -36 lines 0 comments Download
M chromeos/ime/input_method_whitelist_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/ime/input_methods.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Seigo Nonaka
Hi Zach, I'd like you to review this CL. Thanks Seigo.
7 years, 6 months ago (2013-06-17 17:16:16 UTC) #1
Zachary Kuznia
lgtm
7 years, 6 months ago (2013-06-18 23:38:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/17266002/7001
7 years, 6 months ago (2013-06-19 05:29:35 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-19 10:40:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/17266002/54001
7 years, 6 months ago (2013-06-19 11:49:32 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-19 14:45:30 UTC) #6
Message was sent while issue was closed.
Change committed as 207239

Powered by Google App Engine
This is Rietveld 408576698