Honor the --boto flag.

Honor the --boto flag in download_from_google_storage.

It appears to be parsed and ignored, seems like a bug to me.

BUG=None
TEST=local/manual.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=207404

[Ryan Tseng, 2013-06-19 21:47:30]

https://codereview.chromium.org/17265012/diff/1/depot_tools/download_from_goo...
File depot_tools/download_from_google_storage.py (right):

https://codereview.chromium.org/17265012/diff/1/depot_tools/download_from_goo...
depot_tools/download_from_google_storage.py:38: def __init__(self, path,
boto_path, timeout=None):
Two of the tests in tests/download_from_google_storage_unittests.py fail due to
the changed method signature.  Can you fix the tests?

[Peter Mayo, 2013-06-19 23:52:17]

https://codereview.chromium.org/17265012/diff/1/depot_tools/download_from_goo...
File depot_tools/download_from_google_storage.py (right):

https://codereview.chromium.org/17265012/diff/1/depot_tools/download_from_goo...
depot_tools/download_from_google_storage.py:38: def __init__(self, path,
boto_path, timeout=None):
On 2013/06/19 21:47:30, Ryan T. wrote:
> Two of the tests in tests/download_from_google_storage_unittests.py fail due
to
> the changed method signature.  Can you fix the tests?

Done.

  $ ./tests/download_from_google_storage_unittests.py |& grep OK
  OK


Would have helped if the presubmit didn't depend on bizarre extra pieces.

** Presubmit ERRORS **
Missing LGTM from someone other than petermayo@chromium.org

Install google_appengine sdk in
/usr/local/google/home/petermayo/clients/tools2/tools/depot_tools/testing_support
or higher up

Presubmit checks took 45.3s to calculate.

[Ryan Tseng, 2013-06-20 00:15:43]

Did you add the tests into the CL? I don't see them.

[Peter Mayo, 2013-06-20 00:18:30]

On 2013/06/20 00:15:43, Ryan T. wrote:
> Did you add the tests into the CL? I don't see them.

D'oh.  Done & checked.

Still trying to get a presubmit to work.

[Ryan Tseng, 2013-06-20 00:21:20]

lgtm

[commit-bot: I haz the power, 2013-06-20 01:40:21]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[M-A Ruel, 2013-06-20 12:03:57]

lgtm

[commit-bot: I haz the power, 2013-06-20 12:14:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petermayo@chromium.org/17265012/10001

[commit-bot: I haz the power, 2013-06-20 12:16:16]

Change committed as 207404