Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: net/disk_cache/simple/simple_index_file.cc

Issue 17265007: Unlink corrupt SimpleCache index files immediately after load. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tryable Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/simple/simple_index_file.cc
diff --git a/net/disk_cache/simple/simple_index_file.cc b/net/disk_cache/simple/simple_index_file.cc
index 529faf15a1ed1c71ecb6a616f3c5480134dfc2b6..c6bc6eaf891dc1a55cc3bd0c3517792324bace1c 100644
--- a/net/disk_cache/simple/simple_index_file.cc
+++ b/net/disk_cache/simple/simple_index_file.cc
@@ -6,6 +6,7 @@
#include <vector>
+#include <base/bind_helpers.h>
#include "base/file_util.h"
#include "base/files/file_enumerator.h"
#include "base/hash.h"
@@ -175,13 +176,23 @@ bool SimpleIndexFile::IsIndexFileStale(const base::FilePath& index_filename) {
// static
scoped_ptr<SimpleIndex::EntrySet> SimpleIndexFile::LoadFromDisk(
const base::FilePath& index_filename) {
+ base::ScopedClosureRunner
+ scoped_index_deleter(base::Bind(base::IgnoreResult(&file_util::Delete),
+ index_filename, false));
+
std::string contents;
if (!file_util::ReadFileToString(index_filename, &contents)) {
LOG(WARNING) << "Could not read Simple Index file.";
return scoped_ptr<SimpleIndex::EntrySet>();
}
- return SimpleIndexFile::Deserialize(contents.data(), contents.size());
+ scoped_ptr<SimpleIndex::EntrySet> entries =
+ SimpleIndexFile::Deserialize(contents.data(), contents.size());
+ if (!entries)
+ return scoped_ptr<SimpleIndex::EntrySet>();
+
+ scoped_index_deleter.Release();
+ return entries.Pass();
}
// static

Powered by Google App Engine
This is Rietveld 408576698