Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 17257004: [Android] Fix NTP bookmark image unit for low resolution device. (Closed)

Created:
7 years, 6 months ago by Kibeom Kim (inactive)
Modified:
7 years, 6 months ago
Reviewers:
Ted C, newt (away)
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Fix NTP bookmark image unit for low resolution device. makeBookmarkItem() function incorrectly converted image size to dip, but actually it is already dip, so we don't need the conversion. This caused 16px x 16px icon to be classified as non-standard favicon(or small) on low resolution(ldpi) devices and as a result, it didn't draw the document background. BUG=238928 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208067

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M chrome/browser/resources/ntp_android/ntp_android.js View 1 5 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Kibeom Kim (inactive)
7 years, 6 months ago (2013-06-21 19:19:36 UTC) #1
Ted C
lgtm
7 years, 6 months ago (2013-06-21 20:50:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/17257004/1
7 years, 6 months ago (2013-06-21 20:59:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/17257004/1
7 years, 6 months ago (2013-06-22 02:37:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/17257004/1
7 years, 6 months ago (2013-06-22 03:04:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/17257004/1
7 years, 6 months ago (2013-06-22 03:19:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/17257004/1
7 years, 6 months ago (2013-06-22 03:32:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/17257004/1
7 years, 6 months ago (2013-06-22 03:41:30 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 16:58:31 UTC) #9
Message was sent while issue was closed.
Change committed as 208067

Powered by Google App Engine
This is Rietveld 408576698