src/ia32/stub-cache-ia32.cc - Issue 17250003: Fix constant function transition. Insert return instruction before returning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 17250003: Fix constant function transition. Insert return instruction before returning. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/stub-cache-ia32.cc

diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc

index f390f88bb965a31f16411591ca418c445b8fd1eb..c0ee28ad490c0972769f0cabc2c0a2615658594a 100644

--- a/src/ia32/stub-cache-ia32.cc

+++ b/src/ia32/stub-cache-ia32.cc

@@ -931,7 +931,11 @@ void StubCompiler::GenerateStoreTransition(MacroAssembler* masm,

OMIT_REMEMBERED_SET,

OMIT_SMI_CHECK);

- if (details.type() == CONSTANT_FUNCTION) return;

+ if (details.type() == CONSTANT_FUNCTION) {

+ ASSERT(value_reg.is(eax));

+ __ ret(0);

+ return;

+ }

int index = transition->instance_descriptors()->GetFieldIndex(

transition->LastAdded());

« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »