drive: Use ResourceMetadataStorage from FileCache

drive: Use ResourceMetadataStorage from FileCache

Add ResourceMetadataStorage::opened_existing_db() to trigger cache file scan at appropriate timing.

BUG=234487
TEST=unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207841

[hashimoto, 2013-06-21 07:07:11]

Please review.
This patch depends on https://codereview.chromium.org/17004011/
("DriveIntegrationService owns ResourceMetadataStorage")

[kinaba, 2013-06-21 07:32:50]

https://codereview.chromium.org/17249004/diff/13001/chrome/browser/chromeos/d...
File chrome/browser/chromeos/drive/file_cache.cc (right):

https://codereview.chromium.org/17249004/diff/13001/chrome/browser/chromeos/d...
chrome/browser/chromeos/drive/file_cache.cc:824: }
When old_data.Initialize() failed, shouldn't we return false?

It is a rare case but I'm wondering whether we should scan cache file directory
in the case
file_util::PathExists(old_db_path) && !old_data.Initialize() &&
!storage_->opened_existing_db().
(And I think we should.)

[hashimoto, 2013-06-21 08:23:41]

https://codereview.chromium.org/17249004/diff/13001/chrome/browser/chromeos/d...
File chrome/browser/chromeos/drive/file_cache.cc (right):

https://codereview.chromium.org/17249004/diff/13001/chrome/browser/chromeos/d...
chrome/browser/chromeos/drive/file_cache.cc:824: }
On 2013/06/21 07:32:50, kinaba wrote:
> When old_data.Initialize() failed, shouldn't we return false?
> 
> It is a rare case but I'm wondering whether we should scan cache file
directory
> in the case
> file_util::PathExists(old_db_path) && !old_data.Initialize() &&
> !storage_->opened_existing_db().
> (And I think we should.)

Amazingly good catch.
Done as you suggested.

[kinaba, 2013-06-21 08:30:53]

lgtm

LGTM

[commit-bot: I haz the power, 2013-06-21 08:33:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/17249004/19001

[commit-bot: I haz the power, 2013-06-21 16:00:11]

Change committed as 207841