Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 17247007: Remove (but leave references to) all of the builtins that we don't need saved (Closed)

Created:
7 years, 6 months ago by not at google - send to devlin
Modified:
7 years, 6 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Remove (but leave references to) all of the builtins that we don't need saved yet. That file is affecting page load speed. BUG=252704 TBR=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/renderer/extensions/safe_builtins.cc View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
Going to TBR this to see if it fixes any tests.
7 years, 6 months ago (2013-06-22 05:40:11 UTC) #1
not at google - send to devlin
The perf regression I mean.
7 years, 6 months ago (2013-06-22 05:40:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/17247007/1
7 years, 6 months ago (2013-06-22 05:40:48 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 14:09:31 UTC) #4
Message was sent while issue was closed.
Change committed as 208030

Powered by Google App Engine
This is Rietveld 408576698