Copy SourceProfile into ExternalProcessImporterClient instead of using a const& since the original …

Copy SourceProfile into ExternalProcessImporterClient instead of using a const& since the original SourceProfile might be deleted before ExternalProcessImporterClient uses it on the IO thread in StartProcessOnIOThread().

BUG=248642, 181499
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207721

[gab, 2013-06-20 15:22:37]

Miranda, please take a look.

Thanks!
Gab

[Miranda Callahan, 2013-06-20 16:15:36]

On 2013/06/20 15:22:37, gab wrote:
> Miranda, please take a look.
> 
> Thanks!
> Gab

Great catch -- thanks. LGTM. Copying a SourceProfile is annoying, but it only
happens on import, and -- it's better than racy crashing. :-P

[gab, 2013-06-20 19:17:37]

On 2013/06/20 16:15:36, Miranda Callahan wrote:
> On 2013/06/20 15:22:37, gab wrote:
> > Miranda, please take a look.
> > 
> > Thanks!
> > Gab
> 
> Great catch -- thanks. LGTM. Copying a SourceProfile is annoying, but it only
> happens on import, and -- it's better than racy crashing. :-P

Right, another solution would have been to either:

1) Have ExternalProcessImporterClient know about the ImporterList and AddRef it.
or
2)  Change ImporterList::source_profiles_ from a
ScopedVector<importer::SourceProfile> to a
ScopedVector<scoped_refptr<importer::SourceProfile> > and then use a
scoped_refptr to store the SourceProfile we care about in
ExternalProcessImporterClient.

Both of these options introduce complexity and after discussing this with
robertshield, we felt it was better to introduce a simple copy (especially that
the performance hit is nothing compared to the IPC serialization for the message
following it...) than to introduce more complexity.

Anyways, just putting this here for reference in case anyone ever wonders why
this is a copy :)!

Cheers!
Gab

[commit-bot: I haz the power, 2013-06-20 19:18:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/17245003/1

[commit-bot: I haz the power, 2013-06-21 05:44:22]

Change committed as 207721