chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc - Issue 17239002: Removes the old ibus based keyboards, and replace them with the ones based on extension IME API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

Issue 17239002: Removes the old ibus based keyboards, and replace them with the ones based on extension IME API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the test failures. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_manager_impl.cc ('k') | chrome/browser/chromeos/input_method/input_method_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

index f06f7ceeb66d4a10e46e522aeaedf289e95fb433..d9a40a7527ff75b58b32932f8ee2b366ce0e9de8 100644

--- a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

@@ -1183,16 +1183,16 @@ TEST_F(InputMethodManagerImplTest,

manager_->SetState(InputMethodManager::STATE_BROWSER_SCREEN);

std::vector<std::string> ids;

ids.push_back(nacl_mozc_us_id);

- ids.push_back("m17n:kn:itrans");

+ ids.push_back(nacl_mozc_jp_id);

EXPECT_TRUE(manager_->EnableInputMethods(ids));

EXPECT_EQ(2U, manager_->GetNumActiveInputMethods());

manager_->ChangeInputMethod(nacl_mozc_us_id);

- manager_->ChangeInputMethod("m17n:kn:itrans");

+ manager_->ChangeInputMethod(nacl_mozc_jp_id);

InitComponentExtension();

InitIBusBus();

EXPECT_EQ(1, mock_ibus_client_->set_global_engine_call_count());

- EXPECT_EQ("m17n:kn:itrans", mock_ibus_client_->latest_global_engine_name());

+ EXPECT_EQ(nacl_mozc_jp_id, mock_ibus_client_->latest_global_engine_name());

}

TEST_F(InputMethodManagerImplTest,