Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 17239002: Removes the old ibus based keyboards, and replace them with the ones based on extension IME API. (Closed)

Created:
7 years, 6 months ago by Shu Chen
Modified:
7 years, 6 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removes the old ibus based keyboards, and replace them with the ones based on extension IME API. BUG=240659 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207547

Patch Set 1 #

Patch Set 2 : WIP: rebasing #

Patch Set 3 : Fix the subfix of migration code as the IME engine ID #

Patch Set 4 : Fix the test failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -115 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M chromeos/ime/input_methods.txt View 1 2 chunks +47 lines, -109 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Shu Chen
7 years, 6 months ago (2013-06-17 08:24:11 UTC) #1
Seigo Nonaka
lgtm, but please submit this after chrome os side become ready. Thank you for taking!
7 years, 6 months ago (2013-06-17 08:26:36 UTC) #2
Shu Chen
Just uploaded a new patch set to fix the subfix of migration code as the ...
7 years, 6 months ago (2013-06-20 06:40:06 UTC) #3
Seigo Nonaka
lgtm
7 years, 6 months ago (2013-06-20 07:39:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/17239002/7001
7 years, 6 months ago (2013-06-20 07:45:45 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on chromium_presubmit HTTP Error 400: Bad Request
7 years, 6 months ago (2013-06-20 10:46:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/17239002/35001
7 years, 6 months ago (2013-06-20 10:48:13 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-20 11:11:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/17239002/35001
7 years, 6 months ago (2013-06-20 11:41:05 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 20:37:31 UTC) #10
Message was sent while issue was closed.
Change committed as 207547

Powered by Google App Engine
This is Rietveld 408576698