Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 17215002: Update IDL compiler lines in sanitize-win-build-log.sed (Closed)

Created:
7 years, 6 months ago by Nils Barth (inactive)
Modified:
7 years, 5 months ago
Reviewers:
haraken, dominicc1
CC:
chromium-reviews, kojih
Visibility:
Public.

Description

We're adding a new idl_compiler.py script and renaming the existing generate-bindings.pl, as part of adding a second IDL compile flow so we can compile with either Python or Perl. We thus need to update this sed script to process the new command lines. (Separate CL b/c build in Blink and this is in Chromium.) Ok to commit, now that the build CL has landed: Issue 18190004: Add Python flow to bindings generation, move dummy-generating IDL files over https://codereview.chromium.org/18190004/ BUG=239771 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211057

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix \. typo #

Patch Set 3 : Update to Python #

Patch Set 4 : Update to final script names #

Total comments: 1

Patch Set 5 : Catch perl.exe too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/sanitize-win-build-log.sed View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Nils Barth (inactive)
FYI, minor follow-up to build splitting (via JSON), to commit after that lands. Don't need ...
7 years, 6 months ago (2013-06-17 04:54:50 UTC) #1
dominicc (has gone to gerrit)
Why wouldn't we do this as part of the change it depends on? https://codereview.chromium.org/17215002/diff/1/build/sanitize-win-build-log.sed File ...
7 years, 6 months ago (2013-06-19 02:42:12 UTC) #2
Nils Barth (inactive)
On 2013/06/19 02:42:12, dominicc wrote: > Why wouldn't we do this as part of the ...
7 years, 6 months ago (2013-06-19 02:49:03 UTC) #3
Nils Barth (inactive)
Revised per Dominic's comments. Also question about "when this can die". https://codereview.chromium.org/17215002/diff/1/build/sanitize-win-build-log.sed File build/sanitize-win-build-log.sed (right): ...
7 years, 6 months ago (2013-06-19 02:49:35 UTC) #4
haraken
I guess it would be better to get back to this CL after landing the ...
7 years, 6 months ago (2013-06-19 03:17:40 UTC) #5
Nils Barth (inactive)
On 2013/06/19 03:17:40, haraken wrote: > I guess it would be better to get back ...
7 years, 6 months ago (2013-06-19 03:19:51 UTC) #6
Nils Barth (inactive)
Hiyas, Now that Python flow CL is landing, we should land this one shortly after, ...
7 years, 5 months ago (2013-07-10 07:55:29 UTC) #7
haraken
LGTM https://codereview.chromium.org/17215002/diff/11001/build/sanitize-win-build-log.sed File build/sanitize-win-build-log.sed (right): https://codereview.chromium.org/17215002/diff/11001/build/sanitize-win-build-log.sed#newcode18 build/sanitize-win-build-log.sed:18: s/^.*"perl".*idl_compiler\.py".*\("[^"]\+\.idl"\).*$/ idl_compiler \1/ perl => python
7 years, 5 months ago (2013-07-11 02:42:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/17215002/16001
7 years, 5 months ago (2013-07-11 03:32:34 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=174580
7 years, 5 months ago (2013-07-11 06:41:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/17215002/16001
7 years, 5 months ago (2013-07-11 06:55:10 UTC) #11
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 10:45:50 UTC) #12
Message was sent while issue was closed.
Change committed as 211057

Powered by Google App Engine
This is Rietveld 408576698