Chromium Code Reviews Chromium Code Reviews
Issue
17208003:
Track NPObject ownership by the originating plugins' NPP identifier. [4/6] (Chrome) (Closed)
DescriptionTrack NPObject ownership by the originating plugins' NPP identifier. [4/6] (Chrome)
This CL makes Chrome-side changes necessary for tracking of
NPObject ownership to out-of-process NPAPI plugin instances.
Ownership information is now included whenever an NPObject
is marshalled across IPC, to be passed when instantiating
NPObjectProxy instances for objects.
In the plugin process each NPObject is tracked to its owning
plugin instance, and browser-owned objects are tracked to a dummy NPP identifier.
This depends upon crrev.com/17220002 and is a prerequisite for crrev.com/17208003.
BUG=152006
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207840
Patch Set 1 #Patch Set 2 : Rebase and fix include. #Patch Set 3 : Temporarily remove check for NULL owner when receiving objects. #
Total comments: 8
Patch Set 4 : Address review comments #Patch Set 5 : Fix DCHECKs and SetDefaultNPObjectOwner callsite #Patch Set 6 : Don't DCHECK(npobject_listeners_.empty()) on channel teardown. #Patch Set 7 : Remove DCHECKs on proxy and stub maps. #
Messages
Total messages: 12 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
