Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1720323002: Update metrics.proto, and set metric descriptions in MetricsData messages (Closed)

Created:
4 years, 10 months ago by dsansome
Modified:
4 years, 10 months ago
Reviewers:
pgervais
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Update metrics.proto, and set metric descriptions in MetricsData messages BUG=548827 Committed: https://chromium.googlesource.com/infra/infra/+/0d98204fe2ef5db939c0188a7ecc898eed0f061e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Undo the go link change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -59 lines) Patch
M infra_libs/ts_mon/common/metrics.py View 2 chunks +2 lines, -2 lines 0 comments Download
M infra_libs/ts_mon/common/test/metrics_test.py View 1 chunk +8 lines, -0 lines 0 comments Download
D infra_libs/ts_mon/common/test/metrics_test.expected/MetricTest.test_serialize_default_target.json View 1 chunk +0 lines, -15 lines 0 comments Download
D infra_libs/ts_mon/common/test/metrics_test.expected/MetricTest.test_serialize_multiple_values.json View 1 chunk +0 lines, -38 lines 0 comments Download
A + infra_libs/ts_mon/common/test/metrics_test.expected/MetricTest.test_serialize_with_description.json View 1 chunk +11 lines, -0 lines 0 comments Download
M infra_libs/ts_mon/protos/metrics.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M infra_libs/ts_mon/protos/metrics_pb2.py View 4 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dsansome
4 years, 10 months ago (2016-02-23 02:11:42 UTC) #3
pgervais
lgtm https://chromiumcodereview.appspot.com/1720323002/diff/1/infra_libs/ts_mon/protos/REAME.md File infra_libs/ts_mon/protos/REAME.md (right): https://chromiumcodereview.appspot.com/1720323002/diff/1/infra_libs/ts_mon/protos/REAME.md#newcode1 infra_libs/ts_mon/protos/REAME.md:1: Updating the *.proto files: see go/updating_tsmon_protos I created ...
4 years, 10 months ago (2016-02-23 17:29:41 UTC) #4
dsansome
https://chromiumcodereview.appspot.com/1720323002/diff/1/infra_libs/ts_mon/protos/REAME.md File infra_libs/ts_mon/protos/REAME.md (right): https://chromiumcodereview.appspot.com/1720323002/diff/1/infra_libs/ts_mon/protos/REAME.md#newcode1 infra_libs/ts_mon/protos/REAME.md:1: Updating the *.proto files: see go/updating_tsmon_protos On 2016/02/23 17:29:41, ...
4 years, 10 months ago (2016-02-24 00:34:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720323002/20001
4 years, 10 months ago (2016-02-24 00:34:54 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 00:42:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/0d98204fe2ef5db939c0188a7ecc8...

Powered by Google App Engine
This is Rietveld 408576698