Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 17198011: Wrap Pepper CDM Content Settings code in defined(ENABLE_PEPPER_CDMS). (Closed)

Created:
7 years, 6 months ago by ddorwin
Modified:
7 years, 6 months ago
Reviewers:
Lei Zhang, xhwang
CC:
chromium-reviews, stuartmorgan+watch_chromium.org, markusheintz_, jam
Visibility:
Public.

Description

Wrap Pepper CDM Content Settings code in defined(ENABLE_PEPPER_CDMS). Also, adds #endif comments to make the tests more readable. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207817

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/content_settings/content_settings_browsertest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ddorwin
7 years, 6 months ago (2013-06-21 00:12:33 UTC) #1
xhwang
lgtm
7 years, 6 months ago (2013-06-21 00:28:09 UTC) #2
ddorwin
thestig, please provided OWNERS approval for these small changes.
7 years, 6 months ago (2013-06-21 00:35:28 UTC) #3
Lei Zhang
7 years, 6 months ago (2013-06-21 00:43:50 UTC) #4
Lei Zhang
lgtm
7 years, 6 months ago (2013-06-21 00:43:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/17198011/1
7 years, 6 months ago (2013-06-21 00:45:36 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 14:42:48 UTC) #7
Message was sent while issue was closed.
Change committed as 207817

Powered by Google App Engine
This is Rietveld 408576698