Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6259)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 171813010: Move ProfileKeyedAPI implementations to take BrowserContext in the constructor (part 1). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: browser_context_ Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
index 3708575809b58f2da741496d707e26fc5a5c848c..f5ddf4109fdd7363fd4db07b1a1deaadb5e2e5c2 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
@@ -50,10 +50,8 @@ ProfileKeyedAPIFactory<FeedbackPrivateAPI>*
return g_factory.Pointer();
}
-FeedbackPrivateAPI::FeedbackPrivateAPI(Profile* profile)
- : profile_(profile),
- service_(FeedbackService::CreateInstance()) {
-}
+FeedbackPrivateAPI::FeedbackPrivateAPI(content::BrowserContext* context)
+ : browser_context_(context), service_(FeedbackService::CreateInstance()) {}
FeedbackPrivateAPI::~FeedbackPrivateAPI() {
delete service_;
@@ -70,7 +68,8 @@ void FeedbackPrivateAPI::RequestFeedback(
const GURL& page_url) {
// TODO(rkc): Remove logging once crbug.com/284662 is closed.
LOG(WARNING) << "FEEDBACK_DEBUG: Feedback requested.";
- if (profile_ && ExtensionSystem::Get(profile_)->event_router()) {
+ if (browser_context_ &&
+ ExtensionSystem::Get(browser_context_)->event_router()) {
FeedbackInfo info;
info.description = description_template;
info.category_tag = make_scoped_ptr(new std::string(category_tag));
@@ -86,13 +85,13 @@ void FeedbackPrivateAPI::RequestFeedback(
scoped_ptr<Event> event(new Event(
feedback_private::OnFeedbackRequested::kEventName, args.Pass()));
- event->restrict_to_browser_context = profile_;
+ event->restrict_to_browser_context = browser_context_;
// TODO(rkc): Remove logging once crbug.com/284662 is closed.
LOG(WARNING) << "FEEDBACK_DEBUG: Dispatching onFeedbackRequested event.";
- ExtensionSystem::Get(profile_)->event_router()->DispatchEventToExtension(
- kFeedbackExtensionId,
- event.Pass());
+ ExtensionSystem::Get(browser_context_)
+ ->event_router()
+ ->DispatchEventToExtension(kFeedbackExtensionId, event.Pass());
}
}

Powered by Google App Engine
This is Rietveld 408576698