Move ProfileKeyedAPI implementations to take BrowserContext in the constructor (part 1).

Move ProfileKeyedAPI implementations to take BrowserContext in the constructor (part 1).

These are a mix of everywhere changing Profile to BrowserContext and simply putting Profile::FromBrowserContext in the constructor (not changing the service's use of Profile*).

BUG=309909
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252496

[Yoyo Zhou, 2014-02-19 22:44:57]

This is about 1/4 of the applicable services.

https://codereview.chromium.org/171813010/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/profile_keyed_api_factory.h (right):

https://codereview.chromium.org/171813010/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/profile_keyed_api_factory.h:70: static T*
GetForProfile(content::BrowserContext* context) {
This is for making the transition easier.

[James Cook, 2014-02-20 17:47:21]

LGTM with a naming nit.  (Yes, I know it will reformat a lot of code, but I
think it's worth it.)

https://codereview.chromium.org/171813010/diff/1/chrome/browser/chromeos/exte...
File chrome/browser/chromeos/extensions/media_player_api.h (right):

https://codereview.chromium.org/171813010/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/media_player_api.h:39:
content::BrowserContext* const context_;
nit: I like to call member variables |browser_context_| because just |context_|
seems too generic.  (Is it a window context? A graphics context? A browser
context?)

I use |context| for function parameters, since you can quickly see from the
function signature that |context| is a BrowserContext.

https://codereview.chromium.org/171813010/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/profile_keyed_api_factory.h (right):

https://codereview.chromium.org/171813010/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/profile_keyed_api_factory.h:70: static T*
GetForProfile(content::BrowserContext* context) {
On 2014/02/19 22:44:57, Yoyo Zhou wrote:
> This is for making the transition easier.

I presume at some point this will become GetForBrowserContext() or just Get()?

[Yoyo Zhou, 2014-02-20 22:44:54]

https://codereview.chromium.org/171813010/diff/1/chrome/browser/chromeos/exte...
File chrome/browser/chromeos/extensions/media_player_api.h (right):

https://codereview.chromium.org/171813010/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/media_player_api.h:39:
content::BrowserContext* const context_;
On 2014/02/20 17:47:21, James Cook wrote:
> nit: I like to call member variables |browser_context_| because just
|context_|
> seems too generic.  (Is it a window context? A graphics context? A browser
> context?)
> 
> I use |context| for function parameters, since you can quickly see from the
> function signature that |context| is a BrowserContext.

This was actually easy to fix with sed and git cl format.

https://codereview.chromium.org/171813010/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/profile_keyed_api_factory.h (right):

https://codereview.chromium.org/171813010/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/profile_keyed_api_factory.h:70: static T*
GetForProfile(content::BrowserContext* context) {
On 2014/02/20 17:47:21, James Cook wrote:
> On 2014/02/19 22:44:57, Yoyo Zhou wrote:
> > This is for making the transition easier.
> 
> I presume at some point this will become GetForBrowserContext() or just Get()?

Sure, we can rename it to Get() later. So the convenience methods
FooService::Get(context) just call
ProfileKeyedAPIFactory<FooService>::Get(context).

[James Cook, 2014-02-20 22:57:27]

lgtm

[Yoyo Zhou, 2014-02-20 22:58:57]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-02-20 22:59:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/171813010/100001

[commit-bot: I haz the power, 2014-02-21 02:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 02:33:02]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Yoyo Zhou, 2014-02-21 03:34:02]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-02-21 03:34:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/171813010/100001

[commit-bot: I haz the power, 2014-02-21 04:36:34]

Change committed as 252496