Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 171773014: Move ContextProvider binding to inside GpuVideoAcceleratorFactory (Closed)

Created:
6 years, 10 months ago by sheu
Modified:
6 years, 10 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Move ContextProvider binding to inside GpuVideoAcceleratorFactory Bind the ContextProvider inside the GpuVideoAcceleratorFactory itself, so the Factory can decide appropriately what to do in casae of binding failure. Also: replace references to RendererGpuVideoAcceleratorFactory with references to its superclass, GpuVideoAcceleratorFactory. BUG=345424 TEST=local build on desktop Linux R=avi@chromium.org, fischman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253259

Patch Set 1 : ceb954ec Initial. #

Total comments: 2

Patch Set 2 : 62121b4f Comment nit. #

Patch Set 3 : 12dbef7e Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M content/public/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/renderer/video_encode_accelerator.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
sheu
fischman@: while you're in the reviewing mood, here's another one. PTAL.
6 years, 10 months ago (2014-02-24 23:59:05 UTC) #1
Ami GONE FROM CHROMIUM
LGTM % please rewrite the comment noted below. It's unclear to me why content/public is ...
6 years, 10 months ago (2014-02-25 00:06:42 UTC) #2
sheu
avi@: PTAL at content/*, which is pretty much everything. Simple change though. Thanks! https://chromiumcodereview.appspot.com/171773014/diff/130001/content/renderer/media/renderer_gpu_video_accelerator_factories.h File ...
6 years, 10 months ago (2014-02-25 00:50:09 UTC) #3
sheu
6 years, 10 months ago (2014-02-25 00:50:33 UTC) #4
Avi (use Gerrit)
lgtm stampity stamp
6 years, 10 months ago (2014-02-25 03:45:50 UTC) #5
sheu
The CQ bit was checked by sheu@chromium.org
6 years, 10 months ago (2014-02-25 06:17:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/171773014/150001
6 years, 10 months ago (2014-02-25 06:47:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/171773014/150001
6 years, 10 months ago (2014-02-25 07:47:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/171773014/150001
6 years, 10 months ago (2014-02-25 09:16:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/171773014/150001
6 years, 10 months ago (2014-02-25 09:34:48 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 09:43:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 09:43:27 UTC) #12
sheu
The CQ bit was checked by sheu@chromium.org
6 years, 10 months ago (2014-02-25 14:47:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/171773014/150001
6 years, 10 months ago (2014-02-25 14:47:27 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 14:48:55 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 14:48:56 UTC) #16
sheu
The CQ bit was checked by sheu@chromium.org
6 years, 10 months ago (2014-02-25 18:54:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/171773014/150001
6 years, 10 months ago (2014-02-25 18:57:09 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 19:01:43 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 19:01:44 UTC) #20
sheu
The CQ bit was checked by sheu@chromium.org
6 years, 10 months ago (2014-02-25 19:25:14 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/171773014/170001
6 years, 10 months ago (2014-02-25 19:25:47 UTC) #22
sheu
Between the previous patchset and this one (which is just a rebase), we've passed enough ...
6 years, 10 months ago (2014-02-25 21:32:17 UTC) #23
sheu
6 years, 10 months ago (2014-02-25 21:33:20 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 manually as r253259 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698