Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 17176024: Add option to enable sampler. (Closed)

Created:
7 years, 6 months ago by dsinclair
Modified:
7 years, 6 months ago
Reviewers:
nduca, pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Add option to enable sampler. This CL plumbs in the ability for trace_ui and devtools to enable the sampling profiler in trace viewer. BUG=trace-viewer:245 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M base/debug/trace_event_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M base/debug/trace_event_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_tracing_handler.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dsinclair
nduca PTAL.
7 years, 6 months ago (2013-06-21 16:05:23 UTC) #1
dsinclair
pfeldman, PTAL for the devtools change.
7 years, 6 months ago (2013-06-21 16:52:33 UTC) #2
nduca
lgtm
7 years, 6 months ago (2013-06-21 22:22:42 UTC) #3
pfeldman
lgtm
7 years, 6 months ago (2013-06-24 18:06:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/17176024/1
7 years, 6 months ago (2013-06-24 18:08:35 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-24 23:25:04 UTC) #6
Message was sent while issue was closed.
Change committed as 208292

Powered by Google App Engine
This is Rietveld 408576698