Improve the look of the avatar label button (views).

Improve the look of the avatar label button (views).

BUG=241387
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208038

[Adrian Kuegel, 2013-06-21 12:50:46]

Scott, can you please review this changelist? This CL does not change any
functionality, just the look of the label which is displayed in the titlebar for
a supervised user (the text is going to change to supervised user, but the CL
for that is still in the commit queue). You can see a screenshot of that label
at the end of the bug description (views_avatar_label_button.png and
views_avatar_label_button_hover.png).

[sky, 2013-06-21 16:28:26]

https://codereview.chromium.org/17176015/diff/2001/chrome/browser/ui/views/av...
File chrome/browser/ui/views/avatar_label.cc (right):

https://codereview.chromium.org/17176015/diff/2001/chrome/browser/ui/views/av...
chrome/browser/ui/views/avatar_label.cc:25: virtual void Paint(const
views::View& view, gfx::Canvas* canvas);
OVERRIDE

https://codereview.chromium.org/17176015/diff/2001/chrome/browser/ui/views/av...
chrome/browser/ui/views/avatar_label.cc:26: private:
nit: newline between 25/26 and DISALLOW_...

https://codereview.chromium.org/17176015/diff/2001/chrome/browser/ui/views/av...
chrome/browser/ui/views/avatar_label.cc:27: views::Painter* hot_painter_;
Document ownership, in fact I'm pretty sure these leak the way you have it now.

[Adrian Kuegel, 2013-06-21 21:19:31]

https://codereview.chromium.org/17176015/diff/2001/chrome/browser/ui/views/av...
File chrome/browser/ui/views/avatar_label.cc (right):

https://codereview.chromium.org/17176015/diff/2001/chrome/browser/ui/views/av...
chrome/browser/ui/views/avatar_label.cc:25: virtual void Paint(const
views::View& view, gfx::Canvas* canvas);
On 2013/06/21 16:28:26, sky wrote:
> OVERRIDE

Done.

https://codereview.chromium.org/17176015/diff/2001/chrome/browser/ui/views/av...
chrome/browser/ui/views/avatar_label.cc:26: private:
On 2013/06/21 16:28:26, sky wrote:
> nit: newline between 25/26 and DISALLOW_...

Done.

https://codereview.chromium.org/17176015/diff/2001/chrome/browser/ui/views/av...
chrome/browser/ui/views/avatar_label.cc:27: views::Painter* hot_painter_;
On 2013/06/21 16:28:26, sky wrote:
> Document ownership, in fact I'm pretty sure these leak the way you have it
now.

Yes, sorry, forgot to use scoped_ptr here.

[sky, 2013-06-21 21:48:10]

LGTM

[commit-bot: I haz the power, 2013-06-21 21:49:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akuegel@chromium.org/17176015/2002

[commit-bot: I haz the power, 2013-06-22 02:36:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akuegel@chromium.org/17176015/2002

[commit-bot: I haz the power, 2013-06-22 14:30:40]

Change committed as 208038