Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Issue 17175019: Add double click and tap handler to minimize attached panels. (Closed)

Created:
7 years, 6 months ago by flackr
Modified:
7 years, 6 months ago
Reviewers:
stevenjb, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add double click and tap handler to minimize attached panels. BUG=246603 TEST=Open a panel (i.e. hangouts) and double click and tap on header. Panel should minimize. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -1 line) Patch
M ash/ash.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/root_window_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
A ash/wm/panels/panel_window_event_handler.h View 1 chunk +35 lines, -0 lines 0 comments Download
A ash/wm/panels/panel_window_event_handler.cc View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
flackr
Added a double click or double tap to minimize panels (attached panels only - by ...
7 years, 6 months ago (2013-06-21 17:15:45 UTC) #1
stevenjb
nice. lgtm.
7 years, 6 months ago (2013-06-21 17:19:13 UTC) #2
flackr
+sky for OWNERS, PTAL, thanks!
7 years, 6 months ago (2013-06-21 17:20:02 UTC) #3
sky
LGTM
7 years, 6 months ago (2013-06-21 19:36:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/17175019/1
7 years, 6 months ago (2013-06-21 19:38:20 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 22:59:56 UTC) #6
Message was sent while issue was closed.
Change committed as 207949

Powered by Google App Engine
This is Rietveld 408576698