Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3565)

Unified Diff: chrome/browser/google_apis/base_requests_unittest.cc

Issue 17175017: Get rid of RequestRegistry (part 6): get rid of RequestRegistry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment fix Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/google_apis/base_requests.cc ('k') | chrome/browser/google_apis/request_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google_apis/base_requests_unittest.cc
diff --git a/chrome/browser/google_apis/base_requests_unittest.cc b/chrome/browser/google_apis/base_requests_unittest.cc
index a0a3f3639d3f6098e30387397867d117819d5344..b6fdcb6e02b013725ab557905aafabeefaa4ac0e 100644
--- a/chrome/browser/google_apis/base_requests_unittest.cc
+++ b/chrome/browser/google_apis/base_requests_unittest.cc
@@ -30,8 +30,6 @@ class FakeGetDataRequest : public GetDataRequest {
virtual ~FakeGetDataRequest() {
}
- using RequestRegistry::Request::NotifyStart;
-
protected:
virtual GURL GetURL() const OVERRIDE {
NOTREACHED(); // This method is not called in tests.
@@ -119,7 +117,6 @@ TEST_F(BaseRequestsTest, GetDataRequestParseValidResponse) {
runner_.get(),
base::Bind(&BaseRequestsTest::GetDataCallback,
base::Unretained(this)));
- get_data_request->NotifyStart();
get_data_request->ParseResponse(HTTP_SUCCESS, kValidJsonString);
// Should wait for a blocking pool task, as the JSON parsing is done in the
@@ -137,7 +134,6 @@ TEST_F(BaseRequestsTest, GetDataRequestParseInvalidResponse) {
runner_.get(),
base::Bind(&BaseRequestsTest::GetDataCallback,
base::Unretained(this)));
- get_data_request->NotifyStart();
get_data_request->ParseResponse(HTTP_SUCCESS, kInvalidJsonString);
// Should wait for a blocking pool task, as the JSON parsing is done in the
« no previous file with comments | « chrome/browser/google_apis/base_requests.cc ('k') | chrome/browser/google_apis/request_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698