Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17175017: Get rid of RequestRegistry (part 6): get rid of RequestRegistry. (Closed)

Created:
7 years, 6 months ago by kinaba
Modified:
7 years, 6 months ago
Reviewers:
hashimoto, tzik
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Get rid of RequestRegistry (part 6): get rid of RequestRegistry. Now all the thing that the class does is to delete request objects. The lifetime management duty is moved to RequestSender. * NotifyStart => no op. * NotifyFinish => sender_->RequestFinished. BUG=164098 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208011

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -138 lines) Patch
M chrome/browser/google_apis/base_requests.h View 1 5 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/google_apis/base_requests.cc View 5 chunks +6 lines, -20 lines 0 comments Download
M chrome/browser/google_apis/base_requests_unittest.cc View 3 chunks +0 lines, -4 lines 0 comments Download
D chrome/browser/google_apis/request_registry.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/google_apis/request_registry.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/browser/google_apis/request_sender.h View 4 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/google_apis/request_sender.cc View 5 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive/api_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
kinaba
ptal. The life time management is still entangled but I hope I can clean it ...
7 years, 6 months ago (2013-06-21 08:08:15 UTC) #1
kinaba
+tzik on the tiny change in sync_file_system/.
7 years, 6 months ago (2013-06-21 08:12:59 UTC) #2
hashimoto
lgtm https://codereview.chromium.org/17175017/diff/5001/chrome/browser/google_apis/base_requests.h File chrome/browser/google_apis/base_requests.h (right): https://codereview.chromium.org/17175017/diff/5001/chrome/browser/google_apis/base_requests.h#newcode77 chrome/browser/google_apis/base_requests.h:77: // using weak pointers, while deprecating RequestRegistry. nit: ...
7 years, 6 months ago (2013-06-21 08:31:53 UTC) #3
kinaba
https://codereview.chromium.org/17175017/diff/5001/chrome/browser/google_apis/base_requests.h File chrome/browser/google_apis/base_requests.h (right): https://codereview.chromium.org/17175017/diff/5001/chrome/browser/google_apis/base_requests.h#newcode77 chrome/browser/google_apis/base_requests.h:77: // using weak pointers, while deprecating RequestRegistry. On 2013/06/21 ...
7 years, 6 months ago (2013-06-21 09:12:31 UTC) #4
hashimoto
lgtm
7 years, 6 months ago (2013-06-21 09:14:38 UTC) #5
tzik
lgtm
7 years, 6 months ago (2013-06-21 11:17:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17175017/9001
7 years, 6 months ago (2013-06-21 16:42:59 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=167758
7 years, 6 months ago (2013-06-21 21:44:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17175017/9001
7 years, 6 months ago (2013-06-22 01:27:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17175017/9001
7 years, 6 months ago (2013-06-22 02:35:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17175017/9001
7 years, 6 months ago (2013-06-22 03:03:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17175017/9001
7 years, 6 months ago (2013-06-22 03:32:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17175017/9001
7 years, 6 months ago (2013-06-22 03:41:15 UTC) #13
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 06:57:26 UTC) #14
Message was sent while issue was closed. 
Change committed as 208011

Powered by Google App Engine
This is Rietveld 408576698