Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1716743002: Better rendering for implicit types. (Closed)

Created:
4 years, 10 months ago by iannucci
Modified:
4 years, 10 months ago
Reviewers:
dnj
CC:
andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/go-render.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Better rendering for implicit types. This will render `map[myString]struct{a, b int}{"key": {1, 2}}` as `map[pkg.myString]struct {a int; b int}{"key":{1, 2}}`. R=dnj@chromium.org BUG= Committed: 43ff38f3966a82ae0c0bf1b9b5e6e240c858e633

Patch Set 1 #

Patch Set 2 : More tests #

Patch Set 3 : Normalize copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -35 lines) Patch
M render/render.go View 1 7 chunks +72 lines, -30 lines 0 comments Download
M render/render_test.go View 1 2 4 chunks +40 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
iannucci
PTAL
4 years, 10 months ago (2016-02-19 07:14:50 UTC) #2
dnj
Seems reasonable, lgtm.
4 years, 10 months ago (2016-02-19 19:36:28 UTC) #3
iannucci
4 years, 10 months ago (2016-02-19 19:51:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
43ff38f3966a82ae0c0bf1b9b5e6e240c858e633 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698