Issue 17167010: Fix minor bugs found in NetworkConnectionHandler code

Issue 17167010: Fix minor bugs found in NetworkConnectionHandler code (Closed)

Created:
7 years, 6 months ago by stevenjb

Modified:
7 years, 6 months ago

Reviewers:
Greg Spencer (Chromium)

CC:
chromium-reviews, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix minor bugs found in NetworkConnectionHandler code * Removed an unused member variable * Use GetStringWithoutPathExpansion consistently except where expansion is desired * Use kProviderTypeProperty (with expansion) instead of kTypeProperty BUG=247104 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208065

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	chromeos/network/network_connection_handler.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
	M	chromeos/network/network_connection_handler.cc	View	1	3 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

gauravsh

Drive by: This could use a better commit description. The referenced bug doesn't really tell ...

7 years, 6 months ago (2013-06-20 17:13:22 UTC) #2

commit-bot: I haz the power