move sync_promo_ui to non-webui-specific directory

move sync_promo_ui to non-webui-specific directory

BUG=247212
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207827

[Jói, 2013-06-19 22:11:08]

LGTM except for include guard in one file, see below.

https://codereview.chromium.org/17167006/diff/1/chrome/browser/ui/sync/sync_p...
File chrome/browser/ui/sync/sync_promo_ui.h (right):

https://codereview.chromium.org/17167006/diff/1/chrome/browser/ui/sync/sync_p...
chrome/browser/ui/sync/sync_promo_ui.h:5: #ifndef
CHROME_BROWSER_UI_WEBUI_SYNC_PROMO_SYNC_PROMO_UI_H_
Include guard is wrong (here and other two places in this file). Did you know
about tools/git/mass-rename.sh and tools/git/move_source_file.py?  I ask because
they normally take care of this automatically.

[sky, 2013-06-19 23:11:56]

When listing multiple reviewers please list who should review what
review. If you picked me for webui, I'm not a good reviewer for that.
Chose one of the more local OWNERs for webui.

On Wed, Jun 19, 2013 at 2:53 PM,  <bcwhite@chromium.org> wrote:
> Reviewers: sky, joi,
>
> Description:
> move sync_promo_ui to non-webui-specific directory
>
> BUG=247212
>
> Please review this at https://codereview.chromium.org/17167006/
>
> SVN Base: http://git.chromium.org/chromium/src.git@master
>
> Affected files:
>   M chrome/browser/chrome_content_browser_client.cc
>   M chrome/browser/first_run/first_run.cc
>   M chrome/browser/prefs/browser_prefs.cc
>   M chrome/browser/profiles/profile_manager.cc
>   M chrome/browser/signin/DEPS
>   M chrome/browser/signin/signin_browsertest.cc
>   M chrome/browser/ui/app_list/chrome_signin_delegate.cc
>   M chrome/browser/ui/auto_login_infobar_delegate.cc
>   M chrome/browser/ui/browser_command_controller.cc
>   M chrome/browser/ui/browser_mac.h
>   M chrome/browser/ui/chrome_pages.h
>   M
> chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
>   M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
>   M chrome/browser/ui/startup/startup_browser_creator_impl.cc
>   M chrome/browser/ui/sync/one_click_signin_helper.h
>   A + chrome/browser/ui/sync/sync_promo_ui.h
>   A + chrome/browser/ui/sync/sync_promo_ui.cc
>   M chrome/browser/ui/views/extensions/extension_installed_bubble.cc
>   M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
>   M chrome/browser/ui/webui/ntp/ntp_login_handler.cc
>   M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
>   M chrome/browser/ui/webui/set_as_default_browser_ui.cc
>   M chrome/browser/ui/webui/signin/login_ui_service.cc
>   M chrome/browser/ui/webui/sync_promo/sync_promo_trial.h
>   M chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc
>   D chrome/browser/ui/webui/sync_promo/sync_promo_ui.h
>   D chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
>   M chrome/browser/ui/webui/sync_setup_handler.cc
>   M chrome/chrome_browser_ui.gypi
>
>

[bcwhite, 2013-06-20 21:26:16]

Scott, I picked you because you apparently have permission into all the various
directories that are affected.

Joi, I picked you because you have restrictions in the DEPS file and are working
on the move of sign-in to //components and figured you would want to look at it.

There's no changes in this CL.  It just moves a file that is no longer webui out
of that directory and into generic UI.

[sky, 2013-06-20 21:43:06]

LGTM (update header guards as Joi pointed out)

[bcwhite, 2013-06-20 21:52:18]

fixed include guard on moved file

[bcwhite, 2013-06-20 21:52:43]

https://codereview.chromium.org/17167006/diff/1/chrome/browser/ui/sync/sync_p...
File chrome/browser/ui/sync/sync_promo_ui.h (right):

https://codereview.chromium.org/17167006/diff/1/chrome/browser/ui/sync/sync_p...
chrome/browser/ui/sync/sync_promo_ui.h:5: #ifndef
CHROME_BROWSER_UI_WEBUI_SYNC_PROMO_SYNC_PROMO_UI_H_
On 2013/06/19 22:11:09, Jói wrote:
> Include guard is wrong (here and other two places in this file). Did you know
> about tools/git/mass-rename.sh and tools/git/move_source_file.py?  I ask
because
> they normally take care of this automatically.

Done.

No, I didn't know about them.  Thanks for the tip.

[Jói, 2013-06-20 22:35:09]

LGTM

[commit-bot: I haz the power, 2013-06-21 05:11:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/17167006/8001

[commit-bot: I haz the power, 2013-06-21 15:24:30]

Change committed as 207827