Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: content/renderer/browser_plugin/browser_plugin.cc

Issue 17165004: <webview>: Partially migrate loadcommit event from content to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nit Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin.cc
diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc
index cd75c2379ed79ae112aa728649a6c64a235e6fd9..0799079cdb942869df20b961ee0de4b86273d25d 100644
--- a/content/renderer/browser_plugin/browser_plugin.cc
+++ b/content/renderer/browser_plugin/browser_plugin.cc
@@ -416,6 +416,11 @@ void BrowserPlugin::Attach(int guest_instance_id) {
guest_instance_id_ = guest_instance_id;
browser_plugin_manager()->AddBrowserPlugin(guest_instance_id, this);
+ std::map<std::string, base::Value*> props;
+ props[browser_plugin::kWindowID] =
+ new base::FundamentalValue(guest_instance_id);
+ TriggerEvent(browser_plugin::kEventInternalAttached, &props);
+
BrowserPluginHostMsg_Attach_Params create_guest_params;
create_guest_params.browser_plugin_instance_id = instance_id_;
create_guest_params.focused = ShouldGuestBeFocused();
@@ -572,12 +577,6 @@ void BrowserPlugin::OnLoadCommit(
current_nav_entry_index_ = params.current_entry_index;
nav_entry_count_ = params.entry_count;
-
- std::map<std::string, base::Value*> props;
- props[browser_plugin::kURL] = new base::StringValue(params.url.spec());
- props[browser_plugin::kIsTopLevel] =
- new base::FundamentalValue(params.is_top_level);
- TriggerEvent(browser_plugin::kEventLoadCommit, &props);
}
void BrowserPlugin::OnLoadHandlerCalled(int guest_instance_id) {

Powered by Google App Engine
This is Rietveld 408576698