content/common/browser_plugin/browser_plugin_constants.h - Issue 17165004: <webview>: Partially migrate loadcommit event from content to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/browser_plugin/browser_plugin_constants.h

Issue 17165004: <webview>: Partially migrate loadcommit event from content to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nit Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/webview/webview_guest.cc ('K') | « content/browser/browser_plugin/browser_plugin_host_browsertest.cc ('k') | content/common/browser_plugin/browser_plugin_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/browser_plugin/browser_plugin_constants.h

diff --git a/content/common/browser_plugin/browser_plugin_constants.h b/content/common/browser_plugin/browser_plugin_constants.h

index e834229e1aa623daa2177b627e30c224c6584915..1d7bd0ad8604a2a2dc40411d22993269c295c722 100644

--- a/content/common/browser_plugin/browser_plugin_constants.h

+++ b/content/common/browser_plugin/browser_plugin_constants.h

@@ -26,6 +26,9 @@ extern const char kMethodInternalAttachWindowTo[];

extern const char kMethodInternalPersistObject[];

extern const char kMethodInternalSetPermission[];

+// Internal events

+extern const char kEventInternalAttached[];

// Attributes.

extern const char kAttributeAutoSize[];

extern const char kAttributeContentWindow[];

@@ -43,7 +46,6 @@ extern const char kEventConsoleMessage[];

extern const char kEventContentLoad[];

extern const char kEventExit[];

extern const char kEventLoadAbort[];

-extern const char kEventLoadCommit[];

extern const char kEventLoadRedirect[];

extern const char kEventLoadStart[];

extern const char kEventLoadStop[];