Issue 1716443004: Deterministic sorting for all map key types.

lgtm w/ nits https://chromiumcodereview.appspot.com/1716443004/diff/1/render/render.go File render/render.go (right): https://chromiumcodereview.appspot.com/1716443004/diff/1/render/render.go#newcode352 render/render.go:352: func cmpForType(t reflect.Type) cmpFn { nit: ...

4 years, 10 months ago (2016-02-19 19:31:10 UTC) #2

iannucci

Committed patchset #2 (id:20001) manually as 9a04cc21af0f2e328bfb81741ec9e8967c4f6541 (presubmit successful).

4 years, 10 months ago (2016-02-19 21:18:08 UTC) #4

iannucci

4 years, 10 months ago (2016-02-19 21:18:28 UTC) #5

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/1716443004/diff/1/render/render.go
File render/render.go (right):

https://chromiumcodereview.appspot.com/1716443004/diff/1/render/render.go#new...
render/render.go:352: func cmpForType(t reflect.Type) cmpFn {
On 2016/02/19 19:31:10, dnj wrote:
> nit: document that this specifically aims to operate on fields/members that
maps
> operate on for equality.

Done.

https://chromiumcodereview.appspot.com/1716443004/diff/1/render/render.go#new...
render/render.go:460: rslt := cmp(a.Field(i), b.Field(i))
On 2016/02/19 19:31:10, dnj wrote:
> nit: if rstl := cmp(); rstl != 0 { ... }

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1716443004: Deterministic sorting for all map key types. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix nits #

Messages