Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 17163002: Added constants for Android user policy to the cloud policy protobufs. (Closed)

Created:
7 years, 6 months ago by Joao da Silva
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Bin, tslo
Visibility:
Public.

Description

Added constants for Android user policy to the cloud policy protobufs. These constants allow the server to determine that the user policies being requested are meant for an Android device. BUG=248527 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206675

Patch Set 1 #

Patch Set 2 : renamed ANDROID to ANDROID_BROWSER #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/policy/proto/cloud/device_management_backend.proto View 1 2 chunks +2 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
@mnissler: PTAL @binzhao, @tslo: FYI
7 years, 6 months ago (2013-06-15 14:20:13 UTC) #1
Joao da Silva
https://codereview.chromium.org/17163002/diff/6001/chrome/browser/policy/proto/cloud/device_management_backend.proto File chrome/browser/policy/proto/cloud/device_management_backend.proto (right): https://codereview.chromium.org/17163002/diff/6001/chrome/browser/policy/proto/cloud/device_management_backend.proto#newcode27 chrome/browser/policy/proto/cloud/device_management_backend.proto:27: ANDROID_BROWSER = 4; // Register for Android Chrome browser ...
7 years, 6 months ago (2013-06-15 14:33:03 UTC) #2
Mattias Nissler (ping if slow)
LGTM, I don't care so much about the name.
7 years, 6 months ago (2013-06-17 05:16:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/17163002/6001
7 years, 6 months ago (2013-06-17 05:22:23 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-17 07:14:26 UTC) #5
Message was sent while issue was closed.
Change committed as 206675

Powered by Google App Engine
This is Rietveld 408576698