Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 17157015: Bug fix: Translate infobar should appear when the user configured so (Closed)

Created:
7 years, 6 months ago by hajimehoshi
Modified:
7 years, 6 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Bug fix: Translate infobar should appear when the user configured so. When the flag --enable-translate-settings is on, the user can configure which language should be translated. When so, even though the page is written in the user's locale language, the infobar should appear. TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M chrome/browser/translate/translate_manager.cc View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hajimehoshi
Can you take a look? Thanks.
7 years, 6 months ago (2013-06-21 09:50:52 UTC) #1
Takashi Toyoshima
title looks wrong, but code lgtm.
7 years, 6 months ago (2013-06-21 10:35:30 UTC) #2
hajimehoshi
Fixed. On 2013/06/21 10:35:30, Takashi Toyoshima (chromium) wrote: > title looks wrong, but code lgtm.
7 years, 6 months ago (2013-06-21 10:37:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/17157015/1
7 years, 6 months ago (2013-06-21 10:38:44 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 14:42:23 UTC) #5
Message was sent while issue was closed.
Change committed as 207816

Powered by Google App Engine
This is Rietveld 408576698