Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 17155020: Fix some timing and display issues with the supervised-user confirmation. (Closed)

Created:
7 years, 6 months ago by Pam (message me for reviews)
Modified:
7 years, 6 months ago
Reviewers:
Sergiu
CC:
chromium-reviews, dbeam+watch-options_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fix some timing and display issues with the supervised-user confirmation. Collect the custodian's signed-in status each time the confirmation dialog is shown, to catch changes in status that happen after the Settings page loads. Also HTML-escape the new profile's name (and the custodian's email, for good measure), so the confirmation-dialog string can be HTML rather than text and the link to the management page can be active. BUG=252860, 252691 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208010

Patch Set 1 #

Patch Set 2 : Updated checkout #

Patch Set 3 : Re-uploading because Rietveld. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -20 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.js View 1 3 chunks +16 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/managed_user_create_confirm.js View 1 1 chunk +18 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Pam (message me for reviews)
Please review. Note that this depends on the changes from the big string CL (https://codereview.chromium.org/17320005/, ...
7 years, 6 months ago (2013-06-21 20:57:11 UTC) #1
Sergiu
lgtm
7 years, 6 months ago (2013-06-21 21:54:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pam@chromium.org/17155020/5002
7 years, 6 months ago (2013-06-22 00:14:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pam@chromium.org/17155020/5002
7 years, 6 months ago (2013-06-22 02:35:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pam@chromium.org/17155020/5002
7 years, 6 months ago (2013-06-22 03:03:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, chromedriver2_unittests, ...
7 years, 6 months ago (2013-06-22 04:43:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pam@chromium.org/17155020/5002
7 years, 6 months ago (2013-06-22 04:43:56 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 06:57:06 UTC) #8
Message was sent while issue was closed.
Change committed as 208010

Powered by Google App Engine
This is Rietveld 408576698